Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shellcheck warnings #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

seboss666
Copy link

I saw yesterday the warnings around shellcheck, and sadly did not notice earlier. So I've reviewed and fixed the warnings regarding it, and tested locally to ensure no more warnings due to my previous changes.

@seboss666
Copy link
Author

OK, was again too quick to check against old versions, and the "quotes around vars" break the split mechanism to validate the version matching the "arch" naming scheme. So don't merge that for now, I'll need to find other workarounds.

@seboss666
Copy link
Author

Hello, I've finally found time to update the code to fix the logic error and skip the splitting for version check. It worked locally, so I pushed the change.

I also tried to update the action version used for the tests, to remove the errors about deprecated /deactivated functions in Github Actions. The linux test pass, but the macos fails. Unfortunately I have no Apple environment to work with locally to try to understand where the problem lies compared tu Ubuntu. So I'm opened to help for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant