Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix shellcheck warnings #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix shellcheck warnings #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3d0e52
fix shellcheck warnings
Mar 5, 2024
a81e75b
add shellcheck exclusion
Apr 2, 2024
bacde14
try upgrade plugin-test action
Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

steps:
- name: asdf_plugin_test
uses: asdf-vm/actions/plugin-test@v1.0.0
uses: asdf-vm/actions/plugin-test@v2.0.0
with:
version: ${{ matrix.popeye }}
command: popeye version
Expand Down
7 changes: 4 additions & 3 deletions bin/install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ get_platform() {

local machine_hardware_name
machine_hardware_name=${ASDF_KUBECTL_OVERWRITE_ARCH:-"$(uname -m)"}
version_short=$(echo ${version}|sed -e 's/^v//')
version_short="${version//v/""}"
# shellcheck disable=SC2206
version_split=( ${version_short//./ } )
case "$machine_hardware_name" in
'x86_64') local cpu_type="amd64" ;;
Expand All @@ -61,9 +62,9 @@ get_platform() {
esac

# Work around arch type on filenames after 0.11.2
if [ "${cpu_type}" == "amd64" ] && [ ${version_split[0]} -eq 0 ] && [ ${version_split[1]} -le 11 ]; then
if [ "${cpu_type}" == "amd64" ] && [ "${version_split[0]}" -eq 0 ] && [ "${version_split[1]}" -le 11 ]; then
cpu_type="x86_64"
if [ ${version_split[1]} -eq 11 ] && [ ${version_split[2]} -gt 1 ]; then
if [ "${version_split[1]}" -eq 11 ] && [ "${version_split[2]}" -gt 1 ]; then
cpu_type="amd64"
fi
fi
Expand Down
Loading