Removing dependence on adcircpy #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WPringle
commented
Jun 10, 2021
WPringle
commented
- [for now] copying over besttrackforcing from adcircpy into tropicalcyclone.atcf module
- removed NWS, BLAdh, geo, and time interval properties as they are related to adcirc inputs
- add test/output folders to .gitignore
- [for now] copying over besttrackforcing from adcircpy into tropicalcyclone.atcf module - removed NWS, BLAdh, geo, and time interval properties as they are related to adcirc inputs - add test/output folders to .gitignore
…rectories to find them
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Jun 14, 2021
* add python script for ensemble vortex generation * Fix code style issues with oitnb * write perturber class * Fix code style issues with oitnb * store variable information in classes * add random test (ignore until stochastic) * Fix code style issues with oitnb * use `pint` for unit conversion and storage (#22) * use `pint` for unit conversion and storage * move perturbations into class implementations * Fix code style issues with oitnb * rename validation time property * re-enable test with deterministic run * add windows to tests * remove environment.yml * use CRS and transformer from `pyproj` * update reference files * Removing dependence on adcircpy (#23) * Removing dependence on adcircpy - [for now] copying over besttrackforcing from adcircpy into tropicalcyclone.atcf module - removed NWS, BLAdh, geo, and time interval properties as they are related to adcirc inputs - add test/output folders to .gitignore * adding some help info for atcf tracks and adding __init__.py to subdirectories to find them * Fix code style issues with oitnb * remove unused imports * refactor / fix plotting * Fix code style issues with oitnb * use inverse geodetic calc to get distance and bearing * update dependencies * update dependencies * explicitly add GDAL * remove GDAL * Fix code style issues with oitnb * update reference files * fix configuration caching * Fix code style issues with oitnb Co-authored-by: William Pringle <[email protected]> Co-authored-by: Lint Action <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.