-
-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use ES modules in src #727
Conversation
Never liked named exports. It's useful, this here is great example for cases when should not be used. Better os and path to remain. |
should I replace |
I used the automatic vscode conversion initially |
only show the main way to import removed redundant imports
test/unit/persistent-file.test.js
looking for a jest expert for this one |
* chore: start version 3 * feat: Use ES modules (#727) * feat: Url search params and remove multiple (#730) * docs: Fixed the missing "=" in options.filter (#732) * docs: fix example * docs: specify what part actually is * docs: fix types * docs: add warning for progress event * docs: finish removing multiples in examples * docs: add example for express as middleware * docs: example handle common internet errors * feat: add corepack support * fix: corepack support * fix: fix examples comment * fix: fix example comment * feat: add firstValues, readBooleans helpers (#757) * feat: add firstValues, readBooleans helpers * feat: export types * docs: document helpers * docs: fix example * fix: #760 (#761) * fix: fix error when there is an error * tests: fix some of the tests (#763) * chore: up supertest jest and nyc * tests: convert to import , fix some tests * test: make malformed boundary as per comment ? * tests: refactor * style: fix some prettier issues (#764) * chore: publish as 3.x tag * docs: add changelog link * docs: typo Co-authored-by: Hrushikesh Das <[email protected]> Co-authored-by: Jimmy Wärting <[email protected]>
todo still:
some tests use dynamic require