Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url search params and remove multiple #730

Merged
merged 5 commits into from
May 4, 2021

Conversation

GrosSacASac
Copy link
Contributor

remove multiples
remove unused qs and querystring dependency

files and fields are always arrays to avoid type errors
use modern URLSearchParams https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams internally

@GrosSacASac GrosSacASac mentioned this pull request Apr 27, 2021
@GrosSacASac
Copy link
Contributor Author

fixes #634, #485, #400, #292

@GrosSacASac GrosSacASac merged commit efa20b0 into 3.x May 4, 2021
@GrosSacASac GrosSacASac deleted the URLSearchParams-and-remove-multiple branch May 4, 2021 08:26
@tunnckoCore
Copy link
Member

I will review it soon.

@GrosSacASac
Copy link
Contributor Author

An utility to force get singular values

const firstValuesOfFields = fields => {
    return Object.fromEntries(Object.entries(fields).map(([key, value]) => {
        return [key, value[0]];    
    }));
};

// ...

form.parse(request, async (err, fieldsM /*files*/) => {
        const fields = firstValuesOfFields(fieldsM);

GrosSacASac added a commit that referenced this pull request Oct 30, 2021
* chore: start version 3

* feat: Use ES modules (#727)

* feat: Url search params and remove multiple (#730)

* docs: Fixed the missing "=" in options.filter (#732)

* docs: fix example

* docs: specify what part actually is

* docs: fix types

* docs: add warning for progress event

* docs: finish removing multiples in examples

* docs: add example for express as middleware

* docs: example handle common internet errors

* feat: add corepack support

* fix: corepack support

* fix: fix examples comment

* fix: fix example comment

* feat: add firstValues, readBooleans helpers (#757)

* feat: add firstValues, readBooleans helpers

* feat: export types

* docs: document helpers

* docs: fix example

* fix: #760 (#761)

* fix: fix error when there is an error

* tests: fix some of the tests  (#763)

* chore: up supertest jest and nyc

* tests: convert to import , fix some tests

* test: make malformed boundary as per comment ?

* tests: refactor

* style: fix some prettier issues (#764)

* chore: publish as 3.x tag

* docs: add changelog link

* docs: typo

Co-authored-by: Hrushikesh Das <[email protected]>
Co-authored-by: Jimmy Wärting <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants