Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update schedule image for Node.js 11 and 12 #379

Merged
merged 1 commit into from
Oct 30, 2018
Merged

update schedule image for Node.js 11 and 12 #379

merged 1 commit into from
Oct 30, 2018

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Oct 25, 2018 •
edited
Loading

Fixes #378

Note that this is based on the current schedule.json and so doesn't include the planned dates for 12 (#371 / #375).

@richardlau richardlau mentioned this pull request Oct 25, 2018
Closed
@richardlau
Copy link
Member Author

Chart was generated using https://github.com/nodejs/lts-schedule and the current schedule.json.

cjihrig
cjihrig approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but might want to regenerate this once #371 lands with the Node 12 info.

mhdawson
mhdawson approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

We now have the updated information about 12.x in the table. Could you please update the image in this PR?

@richardlau
update schedule image for Node.js 11 and 12
677810e 
Generated using https://github.com/nodejs/lts-schedule

```
$ npx lts -s 2018-9-30 -e 2020-10-31 -d "$PWD/schedule.json" -p
"$PWD/schedule.png"
```
@richardlau
Copy link
Member Author

Rebased to pick up the current schedule.json and regenerated the image via:

$ npx lts -s 2018-9-30 -e 2020-10-31 -d "$PWD/schedule.json" -p "$PWD/schedule.png"

Start date (-s) is end of September so that the chart labels October 2018 at the left edge of the horizontal axis.

End date (-e) gives two years time-span (matches current image time-span of two years).

$PWD to pass fully qualified paths to lts as it looks like npx switches the current directory.

@richardlau richardlau changed the title update schedule image for Node.js 11 update schedule image for Node.js 11 and 12 Oct 27, 2018
@aduh95 aduh95 mentioned this pull request Oct 28, 2018
Merged
@MylesBorins MylesBorins merged commit e82fc16 into nodejs:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richardlau @MylesBorins @targos @cjihrig @mhdawson