Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update schedule image for Node.js 11 and 12 #380

Merged
merged 1 commit into from
Jan 29, 2019
Merged

update schedule image for Node.js 11 and 12 #380

merged 1 commit into from
Jan 29, 2019

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 28, 2018

This is a rework of #379 but using SVG instead of PNG.

SVG is widely supported across browser, and it offers a better quality while reducing the file size significantly (PNG: 47kiB, SVG: 7.71kiB, optimised SVG: 5.75kiB, gzipped optimised SVG: 1.09kiB).

Generated using https://github.com/nodejs/lts-schedule, optimised using SVGo

$ npx lts -s 2018-9-30 -e 2020-10-31 -d "$PWD/schedule.json" -g
"$PWD/schedule.svg"
$ npx svgo "$PWD/schedule.svg"

@aduh95 aduh95 force-pushed the update-chart branch 2 times, most recently from df84dd7 to 9c55ebe Compare October 28, 2018 18:36
@MylesBorins
Copy link
Contributor

@aduh95 can you please rebase

@aduh95
Copy link
Contributor Author

aduh95 commented Oct 30, 2018

@MylesBorins Done!

MylesBorins
MylesBorins approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@fhemberger fhemberger mentioned this pull request Nov 7, 2018
Closed
fhemberger added a commit to nodejs/nodejs.org that referenced this pull request Nov 7, 2018
@fhemberger
Add Release Schedule
dbb6080 
Pulls data from nodejs/Release#380

Fixes: #1889
@fhemberger fhemberger mentioned this pull request Nov 7, 2018
Merged
fhemberger added a commit to nodejs/nodejs.org that referenced this pull request Nov 11, 2018
@fhemberger
Add Release Schedule
a159b1c 
Pulls data from nodejs/Release#380

Fixes: #1889
@MylesBorins
Copy link
Contributor

This is now out of date based on current schedule. Care to rebase / update?

MylesBorins
MylesBorins approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins merged commit 2bf2ea3 into nodejs:master Jan 29, 2019
Martii added a commit to OpenUserJS/OpenUserJS.org that referenced this pull request Jan 30, 2019
@Martii
Update README.md
68ebc62 
Fix *node* schedule image/link from change in nodejs/Release#380
@richardlau richardlau mentioned this pull request Apr 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aduh95 @MylesBorins