chore: add Windows with VS 2022 and Node.JS 19.x to the CI matrix #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhdawson
reviewed
Dec 16, 2022
.github/workflows/ci-win.yml
Outdated
| node-version: [14.x, 16.x, 18.x] | ||
| os: | ||
| - windows-2019 | ||
| node-version: [14.x, 16.x, 18.x] |
There was a problem hiding this comment.
we should probably ad 19.x here as well
There was a problem hiding this comment.
Good point! Let me try adding it,
There was a problem hiding this comment.
@mhdawson , I have added Node.JS 19.x and updated the PR description.
Should I add Node.JS 19.x for non-Windows platforms in this PR too?
There was a problem hiding this comment.
@vmoroz yes, we should have it for all platforms. We probably should have done it in Oct when 19.x was cut.
There was a problem hiding this comment.
OK, I will do it then, while I am editing these files anyway. :)
There was a problem hiding this comment.
@mhdawson , I have added Node.JS 19x to the MacOS and Ubuntu runners. I also cleaned up the script a bit.
vmoroz
changed the title
legendecas
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we are adding
windows-2022OS image to the CI to test Node-API with Visual Studio 2022.We are also adding verification for Node.JS version 19.x.
The new verification matrix for Windows is:
windows-2022- Node,JS [16.x,18.x,19.x]windows-2019- Node,JS [14.x,16.x,18.x,19.x]Note that VS 2022 is not supported by Node.JS 14.x GYP and it is not in the matrix.
For the MacOS and Ubuntu we have added printing of compiler version.
It helped to identify that:
gccis an alias forclang. So, we are removing theMacOS + gccfrom the test matrix."${{ matrix.os }}" = ubuntu-*seems to always fail and we never install the GCC version 6.5. Fixing this condition caused the script error because the package could not be found. CI uses preinstalled GCC version with the Ubuntu image which is currently11.3. Thus, the custom logic to install compiler is removed.The new verification matrix for MacOS and Ubuntu is:
ubuntu-latest- compiler: [gcc,clang] - Node,JS [14.x,16.x,18.x,19.x]macos-latest- compiler: [clang] - Node,JS [14.x,16.x,18.x,19.x]