Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add Windows with VS 2022 and Node.JS 19.x to the CI matrix #1252

Merged
merged 10 commits into from
Dec 19, 2022
Merged

chore: add Windows with VS 2022 and Node.JS 19.x to the CI matrix #1252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1781d59
chore: add Windows and VS 2022 to the CI matrix
vmoroz Dec 16, 2022
90d7bda
apply windows-2022 only to node 18.x
vmoroz Dec 16, 2022
9afe67f
add Node 19.x to the test matrix for Windows
vmoroz Dec 16, 2022
e1285f6
add Node.JS 19.x to MacOS and Ubuntu runners
vmoroz Dec 16, 2022
2076cd1
Fix variable name
vmoroz Dec 16, 2022
a01886b
remove unused code to setup gcc 6.5
vmoroz Dec 17, 2022
75efc57
remove macos-latest + gcc from the matrix
vmoroz Dec 17, 2022
bbddeb8
try to fix the MacOS test matrix
vmoroz Dec 17, 2022
47ccdde
try an alternative way to exclude macos-gcc
vmoroz Dec 17, 2022
1a12f9a
use alternative syntax to exclude Node 14.x/window-2022
vmoroz Dec 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci-win.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,13 @@ jobs:
timeout-minutes: 30
strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
node-version: [ 14.x, 16.x, 18.x, 19.x ]
os:
- windows-2019
- windows-2022
exclude:
- node-version: 14.x
os: windows-2022 # Node.JS 14.x GYP does not support Visual Studio 2022
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand Down
28 changes: 13 additions & 15 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,19 @@ jobs:
timeout-minutes: 30
strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
compiler:
- gcc
- clang
node-version: [ 14.x, 16.x, 18.x, 19.x ]
os:
- ubuntu-latest
- macos-latest
- ubuntu-latest
compiler:
- clang
- gcc
exclude:
- os: macos-latest
compiler: gcc # GCC is an alias for clang on the MacOS image.
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- name: Install system dependencies
run: |
if [ "${{ matrix.compiler }}" = "gcc" -a "${{ matrix.os }}" = ubuntu-* ]; then
sudo add-apt-repository ppa:ubuntu-toolchain-r/test
sudo apt-get update
sudo apt-get install g++-6.5
fi
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
Expand All @@ -40,12 +36,14 @@ jobs:
if [ "${{ matrix.compiler }}" = "gcc" ]; then
export CC="gcc" CXX="g++"
fi
if [ "${{ matrix.compiler }}" = "gcc" -a "${{ matrix.os }}" = ubuntu-* ]; then
export CC="gcc-6.5" CXX="g++-6.5" AR="gcc-ar-6.5" RANLIB="gcc-ranlib-6.5" NM="gcc-nm-6.5"
fi
if [ "${{ matrix.compiler }}" = "clang" ]; then
export CC="clang" CXX="clang++"
fi
echo "CC=\"$CC\" CXX=\"$CXX\""
echo "$CC --version"
$CC --version
echo "$CXX --version"
$CXX --version
export CFLAGS="$CFLAGS -O3 --coverage" LDFLAGS="$LDFLAGS --coverage"
echo "CFLAGS=\"$CFLAGS\" LDFLAGS=\"$LDFLAGS\""
npm run pretest -- --verbose
Expand Down