gyp: fix IPHONEOS_DEPLOYMENT_TARGET #1737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If IPHONEOS_DEPLOYMENT_TARGET is specified, don't append MACOSX_DEPLOYMENT_TARGET flags.
|
Could you upstream this to https://github.com/refack/GYP since there changes get much more extensive CI testing (BTW any help in stabilizing refack/GYP3#35 would be much appreciated). |
|
P.S. @shawwn thank you very much for the contribution 🎩 |
|
@refack Sure, here you go: refack/GYP3#42 |
|
got merged at refack/GYP3#42, I assume that'll come back here at some point soon @refack? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If IPHONEOS_DEPLOYMENT_TARGET is specified, don't append MACOSX_DEPLOYMENT_TARGET flags.
When building for iOS, it's an error to have both
-mmacosx-version-min=...and-miphoneos-version-min=...compiler flags.This PR ensures that if IPHONEOS_DEPLOYMENT_TARGET is specified, no
-mmacosx-version-min=...flags will be emitted.Checklist
npm install && npm testpassesDescription of change