-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Cleanup xcode detect etc #35
Open
refack
wants to merge
12
commits into
master
Choose a base branch
from
cleanup-xcode-detect-etc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cclauss PTAL? |
cclauss
reviewed
Apr 3, 2019
cclauss
reviewed
Apr 3, 2019
cclauss
reviewed
Apr 3, 2019
cclauss
reviewed
Apr 3, 2019
refack
force-pushed
the
cleanup-xcode-detect-etc
branch
from
April 3, 2019 22:07
9856c4e
to
e994cb5
Compare
Found the main issue (lists and *args and bears oh my!) |
refack
force-pushed
the
cleanup-xcode-detect-etc
branch
2 times, most recently
from
April 12, 2019 20:37
35649b1
to
5a2f673
Compare
refack
force-pushed
the
cleanup-xcode-detect-etc
branch
from
April 28, 2019 21:13
503a882
to
7db71f7
Compare
Errors from https://travis-ci.com/refack/GYP/jobs/196474940:
|
|
|
|
|
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.