https: add Server#setTimeout()

[bnoordhuis]

Commit d258fb0 added http.Server#setTimeout() but not https.Server#setTimeout(). I suggest adding that last one in v0.10.

/cc @isaacs

[afshinm]

@isaacs Is there any different to define an HTTP server or HTTPS? I mean different functions? I think I can do this issue.

[bnoordhuis]

@afshinm I already had a patch for this ready, just hadn't submitted it yet. Dusted off and submitted in #5388.

[FelikZ]

Have the following error using node v0.10.29 / v0.10.35:

TypeError: Object #<Server> has no method 'setTimeout'

The code:

            var server = null;
            if (serverConfig.protocol == 'https') {

                var options = { 
                    key: fs.readFileSync(serverConfig.ssl.key),
                    cert: fs.readFileSync(serverConfig.ssl.cert)
                };  

                server = https.createServer(options, app);
            }   
            else {
                server = http.createServer(app);
            } 

            if ('timeout' in serverConfig) {
                server.setTimeout(serverConfig.timeout);
            } 

What I am doing wrong? In http version this code works, but not with https. Looks like the functions is still missing.

[cjihrig]

I don't think this ever landed on the 0.10 branch. If you try in the latest 0.11 or 0.12 code, it should work.

[FelikZ]

@cjihrig thanks for the response. Because https doesn't limits time of sockets I had stacking connections on production server that have lifetime up to node restart, causing connection limit on the server. Currently moved ssl logic to nginx and proxy them to node http.

I think this should be definitely merged into 0.10.

[martindale]

This one bit me, too. Would really love if a maintenance update for 0.10 included this patch.