Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 6.0 failures #7

Closed
targos opened this issue Jun 20, 2017 · 1 comment
Closed

V8 6.0 failures #7

targos opened this issue Jun 20, 2017 · 1 comment

Comments

@targos
Copy link
Member

targos commented Jun 20, 2017

I am starting to test Node.js with V8 6.0 (which will be stable in about one month) and there are some failures on some platforms.
CI run: https://ci.nodejs.org/job/node-test-commit/10683/

ubuntu1404-32

Run: https://ci.nodejs.org/job/node-test-commit-linux/10702/nodes=ubuntu1404-32/console
Test error:

not ok 51 async-hooks/test-zlib.zlib-binding.deflate
  ---
  duration_ms: 0.517
  severity: crashed
  stack: |-
    oh no!
    exit code: CRASHED (Signal: 11)

This error does not happen with the canary branch: https://ci.nodejs.org/job/node-test-commit-linux/10692/nodes=ubuntu1404-32/console

smartos15-64 and smartos16-64

Runs: https://ci.nodejs.org/job/node-test-commit-smartos/9743/nodes=smartos15-64/console and https://ci.nodejs.org/job/node-test-commit-smartos/9743/nodes=smartos16-64/console

Build error:
  LD_LIBRARY_PATH=/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/lib.host:/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj/gen; tools/genv8constants.py "/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj/gen/v8constants.h" "/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a"
  g++ '-DV8_GYP_BUILD' '-DV8_TARGET_ARCH_X64' '-D__C99FEATURES__=1' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' '-DUCONFIG_NO_LEGACY_CONVERSION=1' -I../deps/v8 -I../. -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -Wall -Wextra -Wno-unused-parameter -m64 -pthreads -fno-strict-aliasing -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++0x -MMD -MF /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/.deps//home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/mksnapshot.o.d.raw   -c -o /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/mksnapshot.o ../deps/v8/src/snapshot/mksnapshot.cc
  g++ -rdynamic -m64 -pthreads -Wl,-z,allextract  -o /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/mksnapshot -Wl,--start-group /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/mksnapshot.o /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_setup.a /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_libbase.a /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_libplatform.a /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_nosnapshot.a /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/tools/icu/libicui18n.a /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_libsampler.a /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/tools/icu/libicuucx.a /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/tools/icu/libicudata.a /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/tools/icu/libicustubdata.a /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a -lnsl -lrt -Wl,--end-group
ld: fatal: symbol 'v8::internal::Builtins::Generate_Adaptor(v8::internal::MacroAssembler*, unsigned char*, v8::internal::Builtins::ExitFrameType)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_InOptimizationQueue(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_JSConstructStubGenericRestrictedReturn(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_JSConstructStubGenericUnrestrictedReturn(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_JSConstructStubApi(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_JSBuiltinsConstructStub(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_ConstructedNonConstructable(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_JSEntryTrampoline(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_JSConstructEntryTrampoline(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_ResumeGeneratorTrampoline(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_InterpreterEntryTrampoline(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_InterpreterPushArgsThenCallImpl(v8::internal::MacroAssembler*, v8::internal::ConvertReceiverMode, v8::internal::TailCallMode, v8::internal::InterpreterPushArgsMode)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_InterpreterPushArgsThenConstructImpl(v8::internal::MacroAssembler*, v8::internal::InterpreterPushArgsMode)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_InterpreterPushArgsThenConstructArray(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_InterpreterEnterBytecodeAdvance(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_InterpreterEnterBytecodeDispatch(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_CompileLazy(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_CompileOptimized(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_CompileOptimizedConcurrent(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_InstantiateAsmJs(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_MakeQuadragenarianCodeYoungAgain(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_MakeQuinquagenarianCodeYoungAgain(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_MakeSexagenarianCodeYoungAgain(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_MakeSeptuagenarianCodeYoungAgain(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_MakeOctogenarianCodeYoungAgain(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_MarkCodeAsExecutedOnce(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_MarkCodeAsExecutedTwice(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_MarkCodeAsToBeExecutedOnce(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_NotifyStubFailure(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_NotifyStubFailureSaveDoubles(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_NotifyDeoptimized(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_NotifySoftDeoptimized(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_NotifyLazyDeoptimized(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_FunctionPrototypeApply(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_FunctionPrototypeCall(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_ReflectApply(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_ReflectConstruct(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_InternalArrayCode(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_ArrayCode(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_NumberConstructor(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_NumberConstructor_ConstructStub(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_StringConstructor(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_StringConstructor_ConstructStub(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_AllocateInNewSpace(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_AllocateInOldSpace(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_Abort(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_ArgumentsAdaptorTrampoline(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_Apply(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_ForwardVarargs(v8::internal::MacroAssembler*, v8::internal::Handle<v8::internal::Code>)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_CallFunction(v8::internal::MacroAssembler*, v8::internal::ConvertReceiverMode, v8::internal::TailCallMode)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_CallBoundFunctionImpl(v8::internal::MacroAssembler*, v8::internal::TailCallMode)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_Call(v8::internal::MacroAssembler*, v8::internal::ConvertReceiverMode, v8::internal::TailCallMode)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_CallWithSpread(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_ConstructFunction(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_ConstructBoundFunction(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_ConstructProxy(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_Construct(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_ConstructWithSpread(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_OnStackReplacement(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_InterpreterOnStackReplacement(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: symbol 'v8::internal::Builtins::Generate_WasmCompileLazy(v8::internal::MacroAssembler*)' is multiply-defined:
	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_base.a(builtins-x64.o) type=FUNC; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/deps/v8/src/libv8_builtins_generators.a(builtins-x64.o) type=FUNC);
ld: fatal: file processing errors. No output written to /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/mksnapshot

This error does not happen with the canary branch (another one does though): https://ci.nodejs.org/job/node-test-commit-smartos/9733/nodes=smartos15-64/console

freebsd10-64

Run: https://ci.nodejs.org/job/node-test-commit-freebsd/9863/nodes=freebsd10-64/console

Build error:
  c++ '-DV8_GYP_BUILD' '-DV8_TARGET_ARCH_X64' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' '-DUCONFIG_NO_LEGACY_CONVERSION=1' -I../deps/v8 -I../. -I/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -D_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1 -fno-strict-aliasing -I/usr/local/include -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++0x -MMD -MF /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/out/Release/.deps//usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/out/Release/obj.target/v8_base/deps/v8/src/wasm/wasm-module.o.d.raw   -c -o /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/out/Release/obj.target/v8_base/deps/v8/src/wasm/wasm-module.o ../deps/v8/src/wasm/wasm-module.cc
Stack dump:
0.	Program arguments: /usr/bin/c++ -cc1 -triple x86_64-unknown-freebsd10.3 -emit-obj -disable-free -disable-llvm-verifier -main-file-name wasm-module.cc -mrelocation-model static -mdisable-fp-elim -relaxed-aliasing -masm-verbose -mconstructor-aliases -munwind-tables -target-cpu x86-64 -ffunction-sections -fdata-sections -coverage-file /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/out/Release/obj.target/v8_base/deps/v8/src/wasm/wasm-module.o -resource-dir /usr/bin/../lib/clang/3.4.1 -D V8_GYP_BUILD -D V8_TARGET_ARCH_X64 -D ENABLE_DISASSEMBLER -D V8_PROMISE_INTERNAL_FIELD_COUNT -D v8_promise_internal_field_count -D V8_INTL_SUPPORT -D ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -D UCONFIG_NO_SERVICE=1 -D UCONFIG_NO_REGULAR_EXPRESSIONS=1 -D U_ENABLE_DYLOAD=0 -D U_STATIC_IMPLEMENTATION=1 -D U_HAVE_STD_STRING=0 -D UCONFIG_NO_BREAK_ITERATION=0 -D UCONFIG_NO_LEGACY_CONVERSION=1 -D _LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1 -I ../deps/v8 -I ../. -I /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/out/Release/obj/gen -I ../deps/v8/include -I ../deps/icu-small/source/i18n -I ../deps/icu-small/source/common -I /usr/local/include -internal-isystem /usr/include/c++/v1 -O3 -Wall -Wextra -Wno-unused-parameter -std=gnu++0x -fdeprecated-macro -fdebug-compilation-dir /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/out -ferror-limit 19 -fmessage-length 0 -pthread -mstackrealign -fno-rtti -fobjc-runtime=gnustep -fdiagnostics-show-option -vectorize-loops -vectorize-slp -o /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/out/Release/obj.target/v8_base/deps/v8/src/wasm/wasm-module.o -x c++ ../deps/v8/src/wasm/wasm-module.cc 
1.	<eof> parser at end of file
2.	Per-file LLVM IR generation
3.	../deps/v8/src/wasm/wasm-module.cc:2675:5: Generating code for declaration 'AsyncCompileJob::CompileTask<0>::CompileTask'
c++: error: unable to execute command: Segmentation fault (core dumped)
c++: error: clang frontend command failed due to signal (use -v to see invocation)
FreeBSD clang version 3.4.1 (tags/RELEASE_34/dot1-final 208032) 20140512
Target: x86_64-unknown-freebsd10.3
Thread model: posix
c++: note: diagnostic msg: PLEASE submit a bug report to https://bugs.freebsd.org/submit/ and include the crash backtrace, preprocessed source, and associated run script.
c++: note: diagnostic msg: 
********************

PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
c++: note: diagnostic msg: /tmp/wasm-module-4f57d0.cpp
c++: note: diagnostic msg: /tmp/wasm-module-4f57d0.sh
c++: note: diagnostic msg: 

********************
deps/v8/src/v8_base.target.mk:629: recipe for target '/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/out/Release/obj.target/v8_base/deps/v8/src/wasm/wasm-module.o' failed

This is the same as in #1 and does not happen on the canary branch anymore: https://ci.nodejs.org/job/node-test-commit-freebsd/9853/nodes=freebsd10-64/console
It could be fixed by nodejs/build#723

@targos
Copy link
Member Author

targos commented Jun 30, 2017

Moved to nodejs/node#14004

@targos targos closed this as completed Jun 30, 2017
nodejs-ci pushed a commit that referenced this issue Oct 27, 2017
Currently when running the test without an internet connection there are
two JavaScript test failures and one cctest. The cctest only fails on
Mac as far as I know. (I've only tested using Mac and Linux thus far).

This commit moves the two JavaScript tests to test/internet.

The details for test_inspector_socket_server.cc:

[ RUN      ] InspectorSocketServerTest.FailsToBindToNodejsHost
make[1]: *** [cctest] Segmentation fault: 11
make: *** [test] Error 2

lldb output:

[ RUN      ] InspectorSocketServerTest.FailsToBindToNodejsHost
Process 63058 stopped
* thread #1: tid = 0x7b175, 0x00007fff96d04384
* libsystem_info.dylib`_gai_simple + 87, queue =
* 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1,
* address=0x0)
    frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87
libsystem_info.dylib`_gai_simple:
->  0x7fff96d04384 <+87>: movw   (%rdx), %ax
    0x7fff96d04387 <+90>: movw   %ax, -0x2a(%rbp)
    0x7fff96d0438b <+94>: movq   %r13, -0x38(%rbp)
    0x7fff96d0438f <+98>: movq   0x18(%rbp), %rcx

(lldb) bt
* thread #1: tid = 0x7b175, 0x00007fff96d04384
* libsystem_info.dylib`_gai_simple + 87, queue =
* 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1,
* address=0x0)
  * frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87
    frame #1: 0x00007fff96cfe98b libsystem_info.dylib`search_addrinfo +
179
    frame #2: 0x00007fff96cfafef libsystem_info.dylib`si_addrinfo + 2255
    frame #3: 0x00007fff96cfa67b libsystem_info.dylib`getaddrinfo + 179
    frame #4: 0x00000001017d8888
cctest`uv__getaddrinfo_work(w=0x00007fff5fbfe210) + 72 at
getaddrinfo.c:102
    frame #5: 0x00000001017d880e
cctest`uv_getaddrinfo(loop=0x000000010287cb80, req=0x00007fff5fbfe1c8,
cb=0x0000000000000000, hostname="nodejs.org", service="0",
hints=0x00007fff5fbfe268) + 734 at getaddrinfo.c:192
    frame #6: 0x000000010171f781
cctest`node::inspector::InspectorSocketServer::Start(this=0x00007fff5fbfe658)
+ 801 at inspector_socket_server.cc:398
    frame #7: 0x00000001016ed590
cctest`InspectorSocketServerTest_FailsToBindToNodejsHost_Test::TestBody(this=0x0000000105001fd0)
+ 288 at test_inspector_socket_server.cc:593

I'm not sure about the exact cause for this but when using a standalone
c program to simulate this it seems like when the ai_flags
`AI_NUMERICSERV` is set, which is done in inspector_socket_server.cc
line 394, the servname (the port in the FailsToBindToNodejsHost test) is
expected to be a numeric port string to avoid looking it up in
/etc/services. When the port is 0 as is it was before this commit the
segment fault occurs but not if it is non-zero.

PR-URL: nodejs/node#16255
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant