Skip to content

Commit

Permalink
build: disable libstdc++ debug containers globally
Browse files Browse the repository at this point in the history
Different parts of the debug build were using differently sized
std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and
sometimes not. That ended about as well as you would expect.

Remove the flag.

Fixes: #30056

PR-URL: #30147
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
  • Loading branch information
bnoordhuis authored and MylesBorins committed Mar 24, 2020
1 parent 435341a commit 2069c4e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
4 changes: 0 additions & 4 deletions common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@
'openssl_fips%': '',
'openssl_no_asm%': 0,

# Some STL containers (e.g. std::vector) do not preserve ABI compatibility
# between debug and non-debug mode.
'disable_glibcxx_debug': 1,

# Don't use ICU data file (icudtl.dat) from V8, we use our own.
'icu_use_data_file_flag%': 0,

Expand Down
8 changes: 0 additions & 8 deletions tools/v8_gypfiles/toolchain.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@
# Print to stdout on Android.
'v8_android_log_stdout%': 0,

# Force disable libstdc++ debug mode.
'disable_glibcxx_debug%': 0,

'v8_enable_backtrace%': 0,

# Enable profiling support. Only required on Windows.
Expand Down Expand Up @@ -1167,11 +1164,6 @@
# Support for backtrace_symbols.
'ldflags': [ '-rdynamic' ],
}],
['OS=="linux" and disable_glibcxx_debug==0', {
# Enable libstdc++ debugging facilities to help catch problems
# early, see http://crbug.com/65151 .
'defines': ['_GLIBCXX_DEBUG=1',],
}],
['OS=="aix"', {
'ldflags': [ '-Wl,-bbigtoc' ],
'conditions': [
Expand Down

0 comments on commit 2069c4e

Please sign in to comment.