build: disable libstdc++ debug containers globally #30147

bnoordhuis · 2019-10-27T14:17:11Z

Make sure _GLIBCXX_DEBUG is (un)defined consistently by turning the
disable_glibcxx_debug in common.gypi into a global variable that
overrides the definition in toolchain.gypi.

Different parts of the debug build were using differently sized
std::vectors and that ended about as well as you would expect.

Fixes: #30056

mhdawson

LGTM

BridgeAR · 2019-12-10T00:52:38Z

@bnoordhuis this failure https://ci.nodejs.org/job/node-test-commit-linux-containered/16694/nodes=ubuntu1804_sharedlibs_debug_x64/console seems to be related.

BridgeAR · 2019-12-25T20:06:38Z

Ping @bnoordhuis

BridgeAR · 2020-01-02T16:05:50Z

@bnoordhuis PTAL at the mentioned failure.

Different parts of the debug build were using differently sized std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and sometimes not. That ended about as well as you would expect. Remove the flag. Fixes: nodejs#30056

nodejs-github-bot · 2020-01-03T14:27:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28158/

bnoordhuis · 2020-01-03T14:31:05Z

Thanks for the ping, Ruben, and sorry for the delay. I decided to simply remove the setting since we want it disabled anyway.

nodejs-github-bot · 2020-01-12T01:04:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28381/

BridgeAR · 2020-01-12T01:05:16Z

It would be good to get a confirmation of some of the LGs, since this has changed since the PR was opened.

richardlau · 2020-01-12T01:22:09Z

common.gypi

@@ -30,10 +30,6 @@
    'openssl_fips%': '',
    'openssl_no_asm%': 0,

-    # Some STL containers (e.g. std::vector) do not preserve ABI compatibility
-    # between debug and non-debug mode.
-    'disable_glibcxx_debug': 1,


So this may not have had the desired effect (being overridden by the value in toolchain.gypi) but I'm a little hesitant about removing it completely from common.gypi from the release lines as that's visible to addon authors using node-gyp.

I know it's not an exact science but GH search doesn't turn up any binding.gyp files nor any JS or TS source files that contain the string disable_glibcxx_debug.

I think it's a pretty safe bet it's unused because it was non-functional anyway.

nodejs-github-bot · 2020-02-09T10:47:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29037/

nodejs-github-bot · 2020-03-09T11:30:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29641/

nodejs-github-bot · 2020-03-11T15:42:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29732/

nodejs-github-bot · 2020-03-12T15:37:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29776/

Different parts of the debug build were using differently sized std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and sometimes not. That ended about as well as you would expect. Remove the flag. Fixes: #30056 PR-URL: #30147 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

addaleax · 2020-03-12T18:50:18Z

Landed in 7f44d2c

Different parts of the debug build were using differently sized std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and sometimes not. That ended about as well as you would expect. Remove the flag. Fixes: #30056 PR-URL: #30147 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 27, 2019