Skip to content

Commit

Permalink
test: fix pummel test failures
Browse files Browse the repository at this point in the history
A handful of tests in `test/pummel` were failing due to undefined
variables.

The tests in pummel are not run in CI or otherwise exercised regularly
so these failures can go unnoticed for a long time.

PR-URL: #6012
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
  • Loading branch information
Trott authored and Myles Borins committed Apr 20, 2016
1 parent 6d9c0c9 commit 8da4bad
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 12 deletions.
9 changes: 4 additions & 5 deletions test/pummel/test-crypto-dh.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');
const crypto = require('crypto');

try {
var crypto = require('crypto');
} catch (e) {
if (!common.hasCrypto) {
console.log('1..0 # Skipped: node compiled without OpenSSL.');
return;
}
Expand Down
2 changes: 1 addition & 1 deletion test/pummel/test-dtrace-jsstack.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ if (os.type() != 'SunOS') {
var frames = [ 'stalloogle', 'bagnoogle', 'doogle' ];

var stalloogle = function(str) {
expected = str;
global.expected = str;
os.loadavg();
};

Expand Down
12 changes: 6 additions & 6 deletions test/pummel/test-net-throttle.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var net = require('net');
const common = require('../common');
const assert = require('assert');
const net = require('net');

var N = 1024 * 1024;
var part_N = N / 3;
const N = 1024 * 1024;
const part_N = N / 3;
var chars_recved = 0;
var npauses = 0;

console.log('build big string');
body = 'C'.repeat(N);
const body = 'C'.repeat(N);

console.log('start server on port ' + common.PORT);

Expand Down

0 comments on commit 8da4bad

Please sign in to comment.