Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix pummel test failures #6012

Closed
wants to merge 1 commit into from
Closed

test: fix pummel test failures #6012

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 2, 2016

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?

Affected core subsystem(s)

test, net, crypto

Description of change

A handful of tests in test/pummel were failing due to undefined
variables.

The tests in pummel are not run in CI or otherwise exercised regularly
so these failures can go unnoticed for a long time.

@Trott Trott added crypto Issues and PRs related to the crypto subsystem. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. lts-watch-v4.x smartos Issues and PRs related to the SmartOS platform. labels Apr 2, 2016
@Trott
Copy link
Member Author

Trott commented Apr 2, 2016

@nodejs/testing

@bnoordhuis
Copy link
Member

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Apr 2, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Apr 4, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2151/

(Since pummel tests aren't run in CI, the only thing that is likely to matter is the linting.)

A handful of tests in `test/pummel` were failing due to undefined
variables.

The tests in pummel are not run in CI or otherwise exercised regularly
so these failures can go unnoticed for a long time.
@Trott
Copy link
Member Author

Trott commented Apr 4, 2016

CI which hopefully won't have a lint failure. :-/ https://ci.nodejs.org/job/node-test-pull-request/2152/

UPDATE: Much better. Only failure was a host going offline before it ran the tests. Once more: https://ci.nodejs.org/job/node-test-pull-request/2153/

Trott added a commit to Trott/io.js that referenced this pull request Apr 4, 2016
A handful of tests in `test/pummel` were failing due to undefined
variables.

The tests in pummel are not run in CI or otherwise exercised regularly
so these failures can go unnoticed for a long time.

PR-URL: nodejs#6012
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@Trott
Copy link
Member Author

Trott commented Apr 4, 2016

Landed in 263222d

@Trott Trott closed this Apr 4, 2016
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
A handful of tests in `test/pummel` were failing due to undefined
variables.

The tests in pummel are not run in CI or otherwise exercised regularly
so these failures can go unnoticed for a long time.

PR-URL: #6012
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
A handful of tests in `test/pummel` were failing due to undefined
variables.

The tests in pummel are not run in CI or otherwise exercised regularly
so these failures can go unnoticed for a long time.

PR-URL: #6012
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
A handful of tests in `test/pummel` were failing due to undefined
variables.

The tests in pummel are not run in CI or otherwise exercised regularly
so these failures can go unnoticed for a long time.

PR-URL: #6012
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
This was referenced Apr 21, 2016
MylesBorins pushed a commit that referenced this pull request May 17, 2016
A handful of tests in `test/pummel` were failing due to undefined
variables.

The tests in pummel are not run in CI or otherwise exercised regularly
so these failures can go unnoticed for a long time.

PR-URL: #6012
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
A handful of tests in `test/pummel` were failing due to undefined
variables.

The tests in pummel are not run in CI or otherwise exercised regularly
so these failures can go unnoticed for a long time.

PR-URL: #6012
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
@Trott Trott deleted the noodle branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. net Issues and PRs related to the net subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants