-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emptying URLSearchParams causes unwanted "?" char #10480
Labels
url
Issues and PRs related to the legacy built-in url module.
whatwg-url
Issues and PRs related to the WHATWG URL implementation.
Comments
3 tasks
Proposed fix: #10486 |
targos
added a commit
to targos/node
that referenced
this issue
Jan 1, 2017
If searchParams becomes empty, query must be set to null. Add missing update of context flags. Fixes: nodejs#10480 PR-URL: nodejs#10486 Reviewed-By: James M Snell <[email protected]>
evanlucas
pushed a commit
that referenced
this issue
Jan 3, 2017
If searchParams becomes empty, query must be set to null. Add missing update of context flags. Fixes: #10480 PR-URL: #10486 Reviewed-By: James M Snell <[email protected]>
evanlucas
pushed a commit
that referenced
this issue
Jan 4, 2017
If searchParams becomes empty, query must be set to null. Add missing update of context flags. Fixes: #10480 PR-URL: #10486 Reviewed-By: James M Snell <[email protected]>
TimothyGu
added
the
whatwg-url
Issues and PRs related to the WHATWG URL implementation.
label
Jan 23, 2017
This was referenced Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
url
Issues and PRs related to the legacy built-in url module.
whatwg-url
Issues and PRs related to the WHATWG URL implementation.
Tested in Chrome and both correctly log the same (second) value.
The text was updated successfully, but these errors were encountered: