url: fix URL query update if searchParams changes #10486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
url
|
/cc @jasnell |
jasnell
approved these changes
Jan 1, 2017
If searchParams becomes empty, query must be set to null. Add missing update of context flags. Fixes: nodejs#10480 PR-URL: nodejs#10486 Reviewed-By: James M Snell <[email protected]>
|
@nodejs/punished ? 😉 |
|
Landed in b465cd0 |
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
If searchParams becomes empty, query must be set to null. Add missing update of context flags. Fixes: #10480 PR-URL: #10486 Reviewed-By: James M Snell <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
If searchParams becomes empty, query must be set to null. Add missing update of context flags. Fixes: #10480 PR-URL: #10486 Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If searchParams becomes empty, query must be set to null.
Add missing update of context flags.
Fixes: #10480
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url