fedora test failure: test-benchmark-crypto

[Fishrock123]

This failed against the unrelated #12490

in https://ci.nodejs.org/job/node-test-commit-linux/9201/nodes=fedora23/console

not ok 29 parallel/test-benchmark-crypto
  ---
  duration_ms: 2.329
  severity: fail
  stack: |-
    
    crypto/aes-gcm-throughput.js
    crypto/aes-gcm-throughput.js len=1 cipher="aes-128-gcm" n=1: 0.006952214115344836
    crypto/aes-gcm-throughput.js len=1 cipher="aes-192-gcm" n=1: 0.004117862541667656
    crypto/aes-gcm-throughput.js len=1 cipher="aes-256-gcm" n=1: 0.006152152078471565
    
    crypto/cipher-stream.js
    crypto/cipher-stream.js api="stream" len=1 type="buf" cipher="AES192" writes=1: 7.300269507811883e-7
    crypto/cipher-stream.js api="stream" len=1 type="buf" cipher="AES256" writes=1: 8.525659430594215e-7
    
    crypto/get-ciphers.js
    crypto/get-ciphers.js v="crypto" n=1: 185.0217150735896
    crypto/get-ciphers.js v="tls" n=1: 294.8083657180323
    
    crypto/hash-stream-creation.js
    crypto/hash-stream-creation.js api="stream" len=1 out="buffer" type="buf" algo="sha256" writes=1: 0.0000012189394019881118
    /home/iojs/build/workspace/node-test-commit-linux/nodes/fedora23/benchmark/run.js:62
          var rate = data.rate.toString().split('.');
                              ^
    
    TypeError: Cannot read property 'toString' of null
        at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/fedora23/benchmark/run.js:62:27)
        at emitTwo (events.js:125:13)
        at ChildProcess.emit (events.js:213:7)
        at process.nextTick (internal/child_process.js:753:12)
        at _combinedTickCallback (internal/process/next_tick.js:73:7)
        at process._tickCallback (internal/process/next_tick.js:104:9)
    
    assert.js:86
      throw new assert.AssertionError({
      ^
    AssertionError: 1 === 0
        at ChildProcess.child.on (/home/iojs/build/workspace/node-test-commit-linux/nodes/fedora23/test/parallel/test-benchmark-crypto.js:34:10)
        at emitTwo (events.js:125:13)
        at ChildProcess.emit (events.js:213:7)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:196:12)

cc @Trott

[Trott]

@joyeecheung I don't suppose you got anywhere looking at #12433, did you? This issue would seem to suggest that it's a problem in run.js itself or something like that and not at all a problem in the http test double.

[Trott]

Failed again today:

https://ci.nodejs.org/job/node-test-commit-linux/9736/nodes=fedora22/console

not ok 28 parallel/test-benchmark-crypto
  ---
  duration_ms: 3.471
  severity: fail
  stack: |-
    
    crypto/aes-gcm-throughput.js
    crypto/aes-gcm-throughput.js len=1 cipher="aes-128-gcm" n=1: 0.007032983467259463
    crypto/aes-gcm-throughput.js len=1 cipher="aes-192-gcm" n=1: 0.007420370125193427
    crypto/aes-gcm-throughput.js len=1 cipher="aes-256-gcm" n=1: 0.007760184683912663
    
    crypto/cipher-stream.js
    crypto/cipher-stream.js api="stream" len=1 type="buf" cipher="AES192" writes=1: 8.224968813154231e-7
    crypto/cipher-stream.js api="stream" len=1 type="buf" cipher="AES256" writes=1: 7.647466927204793e-7
    
    crypto/get-ciphers.js
    crypto/get-ciphers.js v="crypto" n=1: 250.8312547783354
    crypto/get-ciphers.js v="tls" n=1: 212.13420373411353
    
    crypto/hash-stream-creation.js
    crypto/hash-stream-creation.js api="stream" len=1 out="buffer" type="buf" algo="sha256" writes=1: 0.0000012591816931824305
    crypto/hash-stream-creation.js api="stream" len=1 out="buffer" type="buf" algo="md5" writes=1: 8.06266245477559e-7
    
    crypto/hash-stream-throughput.js
    crypto/hash-stream-throughput.js api="stream" len=1 type="buf" algo="sha1" writes=1: 0.0000012913913886547416
    crypto/hash-stream-throughput.js api="stream" len=1 type="buf" algo="sha256" writes=1: 8.427605549710038e-7
    /home/iojs/build/workspace/node-test-commit-linux/nodes/fedora22/benchmark/run.js:62
          var rate = data.rate.toString().split('.');
                              ^
    
    TypeError: Cannot read property 'toString' of null
        at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/fedora22/benchmark/run.js:62:27)
        at emitTwo (events.js:125:13)
        at ChildProcess.emit (events.js:213:7)
        at process.nextTick (internal/child_process.js:755:12)
        at _combinedTickCallback (internal/process/next_tick.js:74:7)
        at process._tickCallback (internal/process/next_tick.js:105:9)
    assert.js:92
      throw new AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: 1 === 0
        at ChildProcess.child.on (/home/iojs/build/workspace/node-test-commit-linux/nodes/fedora22/test/parallel/test-benchmark-crypto.js:34:10)
        at emitTwo (events.js:125:13)
        at ChildProcess.emit (events.js:213:7)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:197:12)

[Trott]

The null probably originates as NaN and gets stringified when process.send() is called, resulting in null. /cc @joyeecheung

EDIT: Oh, or perhaps more likely, Infinity instead of NaN.

[joyeecheung]

@Trott I got stuck because I didn't think of the NaN/Infinity -> null thing..thanks for figuring this one out!

[Trott]

This has been resolved since (I think) May. Closing.