Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: pipe some error output if npm fails #12490

Closed
wants to merge 1 commit into from
Closed

test: pipe some error output if npm fails #12490

wants to merge 1 commit into from

Conversation

Fishrock123
Copy link
Contributor

@Fishrock123 Fishrock123 commented Apr 18, 2017 •
edited
Loading

This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

Refs: #12480

CI: https://ci.nodejs.org/job/node-test-pull-request/7485/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@Fishrock123
test: pipe some error output if npm fails
7b77b1e 
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

Refs: nodejs#12480
@Fishrock123 Fishrock123 added the npm Issues and PRs related to the npm client dependency or the npm registry. label Apr 18, 2017
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 18, 2017
@mscdex
Copy link
Contributor

mscdex commented Apr 18, 2017

FWIW I have made a similar change already in #12105.

@Fishrock123 Fishrock123 mentioned this pull request Apr 18, 2017
Closed
@BridgeAR
Copy link
Member

Landed in 99c478e

@BridgeAR BridgeAR closed this Aug 26, 2017
BridgeAR pushed a commit that referenced this pull request Aug 26, 2017
@Fishrock123 @BridgeAR
test: pipe some error output if npm fails
99c478e 
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: #12490
Refs: #12480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@Fishrock123
test: pipe some error output if npm fails
d1c9e17 
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: nodejs/node#12490
Refs: nodejs/node#12480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@Fishrock123
test: pipe some error output if npm fails
3d2ef8d 
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: nodejs/node#12490
Refs: nodejs/node#12480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@Fishrock123 @MylesBorins
test: pipe some error output if npm fails
440f2fc 
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: #12490
Refs: #12480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@Fishrock123 @MylesBorins
test: pipe some error output if npm fails
f694ea6 
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: #12490
Refs: #12480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Fishrock123 Fishrock123 deleted the more-info-npm-test branch September 19, 2017 18:31
MylesBorins pushed a commit that referenced this pull request Sep 20, 2017
@Fishrock123 @MylesBorins
test: pipe some error output if npm fails
8b04574 
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: #12490
Refs: #12480
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Fishrock123 @mscdex @BridgeAR @jasnell @cjihrig @MylesBorins @nodejs-github-bot