doc: remove invalid hash in link #15542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sections in the https://tools.ietf.org/html/rfc1122 are not linkable anymore. Replace the possibly confusing hash with the explicit section number in the text.
nodejs-github-bot
added
doc
refack
reviewed
Sep 21, 2017
| @@ -1000,7 +1000,7 @@ If `allowHalfOpen` is set to `true`, when the other end of the socket | |||
| sends a FIN packet, the server will only send a FIN packet back when | |||
| [`socket.end()`][] is explicitly called, until then the connection is | |||
| half-closed (non-readable but still writable). See [`'end'`][] event | |||
| and [RFC 1122][half-closed] for more information. | |||
| and [RFC 1122][half-closed] (section 4.2.2.13) for more information. | |||
There was a problem hiding this comment.
What exactly should stay? I have not removed here anything, I've just added a note.
There was a problem hiding this comment.
Read this other way around 🤦♂️
| @@ -1125,7 +1125,7 @@ Returns true if input is a version 6 IP address, otherwise returns false. | |||
| [Identifying paths for IPC connections]: #net_identifying_paths_for_ipc_connections | |||
| [Readable Stream]: stream.html#stream_class_stream_readable | |||
| [duplex stream]: stream.html#stream_class_stream_duplex | |||
| [half-closed]: https://tools.ietf.org/html/rfc1122#section-4.2.2.13 | |||
| [half-closed]: https://tools.ietf.org/html/rfc1122 | |||
There was a problem hiding this comment.
Maybe replace with https://tools.ietf.org/html/rfc1122#page-87
@jasnell might have an idea how it is best to ref the RFC?
There was a problem hiding this comment.
I was thinking about the page hash, but it opens a doc with the wrong section in the top which also may be confusing.
|
cc @nodejs/documentation |
BridgeAR
approved these changes
Sep 25, 2017
jasnell
approved these changes
Sep 25, 2017
|
@refack Are you -1 on this? |
refack
approved these changes
Sep 25, 2017
Nope. I'm +1. |
vsemozhetbyt
added a commit
that referenced
this pull request
Sep 25, 2017
Sections in the https://tools.ietf.org/html/rfc1122 are not linkable anymore. Replace the possibly confusing hash with the explicit section number in the text. PR-URL: #15542 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
|
Landed in ebc58d7 |
jasnell
pushed a commit
that referenced
this pull request
Sep 26, 2017
Sections in the https://tools.ietf.org/html/rfc1122 are not linkable anymore. Replace the possibly confusing hash with the explicit section number in the text. PR-URL: #15542 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 29, 2017
Sections in the https://tools.ietf.org/html/rfc1122 are not linkable anymore. Replace the possibly confusing hash with the explicit section number in the text. PR-URL: #15542 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 30, 2017
Sections in the https://tools.ietf.org/html/rfc1122 are not linkable anymore. Replace the possibly confusing hash with the explicit section number in the text. PR-URL: nodejs/node#15542 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Sections in the https://tools.ietf.org/html/rfc1122 are not linkable anymore. Replace the possibly confusing hash with the explicit section number in the text.