Backport WHATWG URL to 6.x #17365
Closed
Backport WHATWG URL to 6.x #17365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add IsInvalidated() method - Add capacity() method for finding out the actual capacity, not the current size, of the buffer - Make IsAllocated() work for invalidated buffers - Allow multiple calls to AllocateSufficientStorage() and Invalidate() - Assert buffer is malloc'd in Release() - Assert buffer has not been invalidated in AllocateSufficientStorage() - Add more descriptive comments describing the purpose of the methods - Add cctest for MaybeStackBuffer PR-URL: nodejs#11464 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#9246 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. PR-URL: nodejs#13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Implements WHATWG URL support. Example:
```
var u = new url.URL('http://example.org');
```
Many, many other commits improving the implementation have been squashed
into this backport PR. They are not listed separately here for brevity.
PR-URL: nodejs#7448
Reviewed-By: Ilkka Myller <[email protected]>
nodejs-github-bot
added
lib / src
TimothyGu
added
c++
This was referenced Nov 28, 2017
|
Wow!!! @nodejs/LTS any concerns around this? We will likely have to wait until the next minor release for this |
cjihrig
approved these changes
Nov 28, 2017
addaleax
added
the
semver-minor
|
Please remember that this should not land on the staging branch until we
are ready to do a minor release
…On Nov 30, 2017 7:03 PM, "Joyee Cheung" ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM with a green CI
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#17365 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAecV0IwOAHJvdDeSeEnZDtl3K0EmueMks5s7n1pgaJpZM4Qst82>
.
|
watilde
approved these changes
Dec 6, 2017
MylesBorins
force-pushed
the
v6.x-staging
branch
from
88b6795
to
3c4bb3c
Compare
|
Looks like either rebasing errors (https://ci.nodejs.org/job/node-test-linter/15225/console) or infra issues (https://ci.nodejs.org/job/node-test-commit-linux/nodes=alpine35-container-x64/15605/console). Maybe something else too as https://ci.nodejs.org/job/node-test-pull-request/12575/ shows "aborted". |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 18, 2018
- Add IsInvalidated() method - Add capacity() method for finding out the actual capacity, not the current size, of the buffer - Make IsAllocated() work for invalidated buffers - Allow multiple calls to AllocateSufficientStorage() and Invalidate() - Assert buffer is malloc'd in Release() - Assert buffer has not been invalidated in AllocateSufficientStorage() - Add more descriptive comments describing the purpose of the methods - Add cctest for MaybeStackBuffer Backport-PR-URL: #17365 PR-URL: #11464 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
ARM failures are unrelated landed in 3c4bb3c...3639d0c |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 18, 2018
Backport-PR-URL: #17365 PR-URL: #9246 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 18, 2018
Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. Backport-PR-URL: #17365 PR-URL: #13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 18, 2018
Implements WHATWG URL support. Example:
```
var u = new url.URL('http://example.org');
```
Many, many other commits improving the implementation have been squashed
into this backport PR. They are not listed separately here for brevity.
Backport-PR-URL: #17365
PR-URL: #7448
Reviewed-By: Ilkka Myller <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2018
- Add IsInvalidated() method - Add capacity() method for finding out the actual capacity, not the current size, of the buffer - Make IsAllocated() work for invalidated buffers - Allow multiple calls to AllocateSufficientStorage() and Invalidate() - Assert buffer is malloc'd in Release() - Assert buffer has not been invalidated in AllocateSufficientStorage() - Add more descriptive comments describing the purpose of the methods - Add cctest for MaybeStackBuffer Backport-PR-URL: #17365 PR-URL: #11464 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2018
Backport-PR-URL: #17365 PR-URL: #9246 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2018
Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. Backport-PR-URL: #17365 PR-URL: #13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2018
Implements WHATWG URL support. Example:
```
var u = new url.URL('http://example.org');
```
Many, many other commits improving the implementation have been squashed
into this backport PR. They are not listed separately here for brevity.
Backport-PR-URL: #17365
PR-URL: #7448
Reviewed-By: Ilkka Myller <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 12, 2018
- Add IsInvalidated() method - Add capacity() method for finding out the actual capacity, not the current size, of the buffer - Make IsAllocated() work for invalidated buffers - Allow multiple calls to AllocateSufficientStorage() and Invalidate() - Assert buffer is malloc'd in Release() - Assert buffer has not been invalidated in AllocateSufficientStorage() - Add more descriptive comments describing the purpose of the methods - Add cctest for MaybeStackBuffer Backport-PR-URL: #17365 PR-URL: #11464 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 12, 2018
Backport-PR-URL: #17365 PR-URL: #9246 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 12, 2018
Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. Backport-PR-URL: #17365 PR-URL: #13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 12, 2018
Implements WHATWG URL support. Example:
```
var u = new url.URL('http://example.org');
```
Many, many other commits improving the implementation have been squashed
into this backport PR. They are not listed separately here for brevity.
Backport-PR-URL: #17365
PR-URL: #7448
Reviewed-By: Ilkka Myller <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 13, 2018
- Add IsInvalidated() method - Add capacity() method for finding out the actual capacity, not the current size, of the buffer - Make IsAllocated() work for invalidated buffers - Allow multiple calls to AllocateSufficientStorage() and Invalidate() - Assert buffer is malloc'd in Release() - Assert buffer has not been invalidated in AllocateSufficientStorage() - Add more descriptive comments describing the purpose of the methods - Add cctest for MaybeStackBuffer Backport-PR-URL: #17365 PR-URL: #11464 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 13, 2018
Backport-PR-URL: #17365 PR-URL: #9246 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 13, 2018
Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. Backport-PR-URL: #17365 PR-URL: #13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 13, 2018
Implements WHATWG URL support. Example:
```
var u = new url.URL('http://example.org');
```
Many, many other commits improving the implementation have been squashed
into this backport PR. They are not listed separately here for brevity.
Backport-PR-URL: #17365
PR-URL: #7448
Reviewed-By: Ilkka Myller <[email protected]>
This was referenced Nov 11, 2024
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes all commits related to the WHATWG URL parser up until now. To ease backporting, many changes to
urldocumentation not directly related to the new parser are also included. For compatibility concerns, the newurl.format(whatwgURLObj)overload and WHATWG URL support infsandhttpare not backported.PRs #11464, #9246, #13362, which the current WHATWG URL implementation requires, are backported in separate commits as they are logically separate, even if the commits themselves were made after the WHATWG parser landed and contained changes to it.
Fixes: nodejs/Release#208
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url