Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport WHATWG URL to 6.x #17365

Closed
wants to merge 4 commits into from
Closed

Backport WHATWG URL to 6.x #17365

wants to merge 4 commits into from

Commits on Nov 28, 2017

  1. src: clean up MaybeStackBuffer 

    - Add IsInvalidated() method
- Add capacity() method for finding out the actual capacity, not the
  current size, of the buffer
- Make IsAllocated() work for invalidated buffers
- Allow multiple calls to AllocateSufficientStorage() and Invalidate()
- Assert buffer is malloc'd in Release()
- Assert buffer has not been invalidated in AllocateSufficientStorage()
- Add more descriptive comments describing the purpose of the methods
- Add cctest for MaybeStackBuffer

PR-URL: nodejs#11464
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @TimothyGu
    TimothyGu committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    2efd843 View commit details
    Browse the repository at this point in the history

  2. test: add common.hasIntl 

    PR-URL: nodejs#9246
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
    @jasnell @TimothyGu
    jasnell authored and TimothyGu committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    eba99fe View commit details
    Browse the repository at this point in the history

  3. url: update IDNA handling 

    Remove custom tests for invalid IDNA domains in url-idna.js in favor of
the more comprehensive official set.

PR-URL: nodejs#13362
Refs: whatwg/url#309
Refs: web-platform-tests/wpt#5976
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
    @TimothyGu
    TimothyGu committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    79147ae View commit details
    Browse the repository at this point in the history

  4. url: adding WHATWG URL support 

    Implements WHATWG URL support. Example:

```
var u = new url.URL('http://example.org');
```

Many, many other commits improving the implementation have been squashed
into this backport PR. They are not listed separately here for brevity.

PR-URL: nodejs#7448
Reviewed-By: Ilkka Myller <[email protected]>
    @jasnell @TimothyGu
    jasnell authored and TimothyGu committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    77d08f9 View commit details
    Browse the repository at this point in the history