Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "repl: refactor tests to not rely on timing" #18715

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Feb 11, 2018

This reverts commit de848ac.

The commit broke multiline repl.

It can easily be checked by trying to write something after entering {.

Refs: #17828

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

repl

This reverts commit de848ac.

The commit broke multiline repl.
@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Feb 11, 2018
@BridgeAR BridgeAR requested a review from bmeck February 11, 2018 18:19
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fast-track this.

@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 11, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 12, 2018
BridgeAR added a commit to BridgeAR/node that referenced this pull request Feb 12, 2018
This reverts commit de848ac.

The commit broke multiline repl.

PR-URL: nodejs#18715
Refs: nodejs#17828
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR
Copy link
Member Author

Landed in 1fc373b

@BridgeAR BridgeAR closed this Feb 12, 2018
cjihrig added a commit to cjihrig/node that referenced this pull request Feb 14, 2018
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: nodejs#18718
Refs: nodejs#17828
Refs: nodejs#18715
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins
Copy link
Contributor

Original didn't land in a release, setting as don't land

/cc @jasnell re: 10

MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
This reverts commit de848ac.

The commit broke multiline repl.

PR-URL: nodejs#18715
Refs: nodejs#17828
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: nodejs#18718
Refs: nodejs#17828
Refs: nodejs#18715
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 8, 2018
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR deleted the revert-17828 branch April 1, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants