Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add multiline repl input regression test #18718

Merged
merged 1 commit into from
Feb 14, 2018
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 11, 2018

This commit adds a regression test for de848ac, which broke multiline input in the REPL.

This will fail until de848ac is reverted or fixed.

Refs: #17828
Refs: #18715

Checklist
  • [] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 11, 2018
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/13119/

@cjihrig please always trigger a CI after creating a PR :-)

This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: nodejs#18718
Refs: nodejs#17828
Refs: nodejs#18715
Reviewed-By: Ruben Bridgewater <[email protected]>
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 14, 2018

New CI, now that the revert landed: https://ci.nodejs.org/job/node-test-pull-request/13176/

@cjihrig cjihrig merged commit 92c86fd into nodejs:master Feb 14, 2018
@cjihrig cjihrig deleted the test branch February 14, 2018 16:47
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: nodejs#18718
Refs: nodejs#17828
Refs: nodejs#18715
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants