ensure preload modules are always preloaded #2253

bmeck · 2015-07-27T16:53:56Z

For consistency -r/--require should always preload modules; right now it works with normal startup, cluster, and eval; having preloading work with stdin and interactive mode would make this more consistent.

thefourtheye · 2015-07-27T18:07:57Z

Will it have impact on startup time?

Fishrock123 · 2015-07-27T18:23:12Z

Will it have impact on startup time?

No not really.

bmeck · 2015-07-27T18:23:30Z

@thefourtheye only when the flag is enabled, otherwise we are looking at a few integer checks for preloaded_module_count

Fishrock123 · 2015-07-27T18:24:38Z

CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/201/

Fishrock123 · 2015-07-27T21:42:47Z

Test is failing on smartos-14 (32 and 64bit):

not ok 535 - test-preload.js
# 
# assert.js:89
# throw new assert.AssertionError({
# ^
# AssertionError: '' == 'A\nhello\n'
# at ChildProcess.<anonymous> (/home/iojs/build/workspace/iojs+pr+other/nodes/smartos14-64/test/parallel/test-preload.js:78:10)
# at emitTwo (events.js:87:13)
# at ChildProcess.emit (events.js:172:7)
# at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)

bmeck · 2015-07-27T22:08:59Z

@Fishrock123 even without this patch it should never be empty... that is... concerning

Fishrock123 · 2015-07-27T22:19:08Z

cc @nodejs/platform-solaris

bmeck · 2015-08-19T14:42:40Z

is there a person I can talk to about this, as I don't run SmartOS normally, and am completely lost as to how it could be empty/worked prior to this.

Fishrock123 · 2015-08-19T16:12:59Z

cc @jbergstroem / @misterdjules again

Fishrock123 · 2015-08-20T22:08:50Z

CI again https://jenkins-iojs.nodesource.com/job/node-test-pull-request/119/

Fishrock123 · 2015-08-22T19:17:34Z

Seems fine to me. @bmeck how do you feel about just ignoring it on smartos?

thefourtheye · 2015-08-22T19:19:37Z

The commit message is too long and commit log has to be improved.

bmeck · 2015-08-22T19:20:56Z

@thefourtheye improved how

Fishrock123 · 2015-08-22T21:41:35Z

test/parallel/test-preload.js

+const fixtureA = fixture('printA.js');
+const fixtureB = fixture('printB.js');
+const fixtureC = fixture('printC.js');
+const fixtureThrows = fixture('throws_error4.js');


I think we'd prefer if you only const unmodified variables you add, but if you want to do these also I really don't mind.

Fishrock123 · 2015-08-22T21:50:15Z

LGTM otherwise, I'll just add some detail to the commit description if you don't. :)

jbergstroem · 2015-08-23T04:04:32Z

I can reproduce this fail but haven't had time to look into it. Would appreciate if @misterdjules had a moment.

bmeck · 2015-08-24T20:20:21Z

rebased. uses camelcase now. repro'd fail on smartos, trying to reduce it

bmeck · 2015-08-31T17:17:11Z

@nodejs/platform-solaris i am unsure how to test this exactly, but is closing stdin before it is fully drained dropping the content on smartos?

rvagg · 2015-09-10T22:29:28Z

ping @No9, perhaps you can lend an eye to this one since you're an Illumos user?

jbergstroem · 2015-09-11T05:15:36Z

If anyone else is using illumos/smartos and would like to help out reviewing that'd be great!

rvagg · 2015-09-11T05:23:50Z

also would love to additional people to @nodejs/platform-solaris if there are any

No9 · 2015-09-11T08:06:51Z

@rvagg I'll look in over the weekend

jbergstroem · 2015-09-11T08:13:16Z

@No9 would you be interested in being part of the small team of people that (in my case, at least tries to) debugs sunos stuff?

No9 · 2015-09-11T08:51:48Z

@jbergstroem Thanks for asking
Yes I would :)

rvagg · 2015-09-11T08:55:12Z

added to @nodejs/platform-solaris, thanks @No9!

mhdawson · 2016-05-12T18:20:51Z

Failed on AIX in last night's run as well #6716

bmeck · 2016-05-12T18:39:25Z

This is starting to look like some sort of race condition

mhdawson · 2016-05-12T20:02:59Z

@bmeck @Fishrock123 on AIX it looks like a consistent failure. If it helps I can give one or both of you access to run on that machine.

Fishrock123 · 2016-05-12T20:05:01Z

We should also skip on AIX for now then, but we do need to investigate more.

This test fails on Solaris, see the PR for discussion. PR-URL: #2253 Reviewed-By: Jeremiah Senkpiel <[email protected]>

MylesBorins · 2016-06-02T00:30:16Z

@bmeck looks like there are some regressions here. Adding dont-land for now, but please feel free to open a PR against v4.x-staging if this should be packported

Fishrock123 · 2016-06-02T16:19:23Z

@thealphanerd No, those are just the result of other issues.

this should be fine if it lands with #6728

MylesBorins · 2016-06-02T16:20:18Z

thanks @Fishrock123 will work on that later today

MylesBorins · 2016-06-29T16:24:38Z

@bmeck would you be willing to do a manual backport of this and #6728 ?

bmeck · 2016-06-29T16:28:08Z

@thealphanerd onto v4?

MylesBorins · 2016-06-29T17:04:22Z

indeed. It is not landing cleanly

MylesBorins · 2016-08-30T12:56:44Z

ping @bmeck

bmeck · 2016-08-30T13:20:29Z

@thealphanerd backported against v4.5.0 (no staging exists right now?) on https://github.com/bmeck/node/tree/backport-2253 , still flaky it seems after running tests

MylesBorins · 2016-08-30T14:05:05Z

the staging is v4.x-staging

If it is still flaky then perhaps we should just mark this don't land?

bmeck · 2016-08-30T14:18:07Z

@thealphanerd these are just adding tests for expected behavior, if we don't want to land it thats fine

MylesBorins · 2016-08-30T14:26:08Z

@bmeck if that is the case then we should land it. Would you be willing to open a PR?

This test fails on Solaris, see nodejs#2253

bmeck · 2016-08-30T14:31:56Z

@thealphanerd #8340

thefourtheye added the module Issues and PRs related to the module subsystem. label Jul 27, 2015

Fishrock123 reviewed Aug 22, 2015
View reviewed changes

bmeck force-pushed the preload-always branch from d2fe924 to eecd3f2 Compare August 24, 2015 20:19

rvagg force-pushed the master branch from 11c25c2 to ba02bd0 Compare September 6, 2015 11:55

Fishrock123 mentioned this pull request Sep 16, 2015

-r / --require should work in interactive. #2892

Closed

Fishrock123 mentioned this pull request May 12, 2016

test: skip test-preload on AIX #6718

Closed

2 tasks

evanlucas pushed a commit that referenced this pull request May 17, 2016

test: test preloaded modules using stdin or repl

0eb25cb

This test fails on Solaris, see the PR for discussion. PR-URL: #2253 Reviewed-By: Jeremiah Senkpiel <[email protected]>

evanlucas mentioned this pull request May 17, 2016

2016-05-17, Version 6.2.0 (Stable) #6810

Merged

MylesBorins added the dont-land-on-v4.x label Jun 2, 2016

Fishrock123 removed the dont-land-on-v4.x label Jun 2, 2016

MylesBorins added the lts-watch-v4.x label Jun 2, 2016

bmeck added a commit to bmeck/node that referenced this pull request Aug 30, 2016

test: test preloaded modules when using stdin or repl

818f46d

This test fails on Solaris, see nodejs#2253

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Sep 4, 2016

ensure preload modules are always preloaded #2253

ensure preload modules are always preloaded #2253

Conversation

bmeck commented Jul 27, 2015

thefourtheye commented Jul 27, 2015

Fishrock123 commented Jul 27, 2015

bmeck commented Jul 27, 2015

Fishrock123 commented Jul 27, 2015

Fishrock123 commented Jul 27, 2015

bmeck commented Jul 27, 2015

Fishrock123 commented Jul 27, 2015

bmeck commented Aug 19, 2015

Fishrock123 commented Aug 19, 2015

Fishrock123 commented Aug 20, 2015

Fishrock123 commented Aug 22, 2015

thefourtheye commented Aug 22, 2015

bmeck commented Aug 22, 2015

Fishrock123 Aug 22, 2015

Choose a reason for hiding this comment

Fishrock123 commented Aug 22, 2015

jbergstroem commented Aug 23, 2015

bmeck commented Aug 24, 2015

bmeck commented Aug 31, 2015

rvagg commented Sep 10, 2015

jbergstroem commented Sep 11, 2015

rvagg commented Sep 11, 2015

No9 commented Sep 11, 2015

jbergstroem commented Sep 11, 2015

No9 commented Sep 11, 2015

rvagg commented Sep 11, 2015

mhdawson commented May 12, 2016

bmeck commented May 12, 2016

mhdawson commented May 12, 2016

Fishrock123 commented May 12, 2016

MylesBorins commented Jun 2, 2016

Fishrock123 commented Jun 2, 2016

MylesBorins commented Jun 2, 2016

MylesBorins commented Jun 29, 2016

bmeck commented Jun 29, 2016

MylesBorins commented Jun 29, 2016

MylesBorins commented Aug 30, 2016

bmeck commented Aug 30, 2016

MylesBorins commented Aug 30, 2016

bmeck commented Aug 30, 2016

MylesBorins commented Aug 30, 2016

bmeck commented Aug 30, 2016