Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip test-preload on AIX #6718

Closed
wants to merge 1 commit into from

Conversation

Fishrock123
Copy link
Contributor

@Fishrock123 Fishrock123 commented May 12, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Refs: #2253 (comment)
Fixes: #6716

cc @bmeck & @mhdawson

Maybe we should be changing this to only skip the stdin part of the test? It seems like that is the bit causing issues?

CI: https://ci.nodejs.org/job/node-test-pull-request/2609/

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 12, 2016
@mhdawson
Copy link
Member

mhdawson commented May 12, 2016

Is this going to be excluded on centos (which I also saw failing in the ci) as well ? Just want to understand if excluding or trying to fix is the right thing to do ?

@Fishrock123
Copy link
Contributor Author

@mhdawson can you point me to a failure?

@Fishrock123
Copy link
Contributor Author

Fishrock123 commented May 12, 2016

Looks like Centos did also fail here:

# 
# assert.js:90
# throw new assert.AssertionError({
# ^
# AssertionError: '' == 'A\nhello\n'
# at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/centos7-64/test/parallel/test-preload.js:86:10)
# at emitTwo (events.js:106:13)
# at ChildProcess.emit (events.js:191:7)
# at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)

@Fishrock123
Copy link
Contributor Author

Looks like @santigimeno has an idea in #6716 (comment)

@Fishrock123 Fishrock123 added the wip Issues and PRs that are still a work in progress. label May 12, 2016
@Trott
Copy link
Member

Trott commented May 13, 2016

Hopeful fix from @santigimeno's idea/comment: #6722

EDIT: Whoops, fixed the link.

@Fishrock123
Copy link
Contributor Author

@Trott that links to nothing?

@Fishrock123
Copy link
Contributor Author

Closing in favor of #6728

@Fishrock123 Fishrock123 deleted the test/skip-preload-aix branch May 13, 2016 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. wip Issues and PRs that are still a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIX - test-preload.js failure
4 participants