src: increment NODE_MODULE_VERSION to 46 #2678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V8 4.5 API changes that warrant this: * Remove deprecated v8::Object::TurnOnAccessCheck API * Remove obsolete options in ScriptCompiler::CompileOptions * Remove v8::Private Full details at https://docs.google.com/document/d/1g8JFi8T_oAE_7uAri7Njtig7fKaPDfotU6huOa1alds/edit?hl=en&forcehl=1
9 tasks
|
LGTM |
ofrobots
added a commit
that referenced
this pull request
Sep 3, 2015
V8 4.5 API changes that warrant this: * Remove deprecated v8::Object::TurnOnAccessCheck API * Remove obsolete options in ScriptCompiler::CompileOptions * Remove v8::Private Full details at https://docs.google.com/document/d/1g8JFi8T_oAE_7uAri7Njtig7fKaPDfotU6huOa1alds/edit?hl=en&forcehl=1 PR-URL: #2678 Reviewed-By: targos - Michaël Zasso <[email protected]>
|
Landed in |
|
Hmmm, normally we'd do this as part of the stable release process rather than coupling it with landing V8. We're going to have to figure out how this fits in with our master/canary/unstable "release" process, I for one don't want to see this number incremented every time a |
|
Yeah it's probably best to leave this to @nodejs/release |
|
Acknowledged. It would simple to drop this commit from #2682 before merging to master. LMK. |
|
Dropped from #2682 and |
|
@ofrobots Can we remove vee-eight-4.5 branch now? |
|
@thefourtheye Done. |
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get this into
vee-eight-4.5before the PR to master.V8 4.5 C++ API changes that warrant this:
R=@rvagg, @nodejs/v8