Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Build node 4.0 binaries - NODE_MODULE_VERSION 46 #1122

Closed
8 of 9 tasks
saper opened this issue Sep 3, 2015 · 49 comments
Closed
8 of 9 tasks

Build node 4.0 binaries - NODE_MODULE_VERSION 46 #1122

saper opened this issue Sep 3, 2015 · 49 comments

Comments

@saper
Copy link
Member

saper commented Sep 3, 2015

node 4.0 will probably import V8 4.5, with minor changes to the V8 API (most probably not relevant to our module). nan upgrade is not required.

node 4.0 milestone

nodejs/node#2632 - import of V8 4.5.103.30

nodejs/node#2678 - NODE_MODULE_VERSION bump to 46

Binaries

  • OSX
  • Linux 32bit
  • Linux 64bit
  • Windows 32bit
  • Windows 64bit
  • FreeBSD 32bit
  • FreeBSD 64bit

Release

  • Back port binaries to v3.3.2
  • Release v3.3.3
@saper saper self-assigned this Sep 3, 2015
@saper saper added this to the node 4.0 milestone Sep 3, 2015
@saper
Copy link
Member Author

saper commented Sep 3, 2015

I can confirm that node some v4.0.0-pre with the new V8 builds and runs node-sass just fine. We just get a new set of modules with a number 46.

@xzyfer
Copy link
Contributor

xzyfer commented Sep 4, 2015

Cool, so we still need to generate binaries, but there's no real work required?

If we don't need to bump nan and do a new release we can just attach the new binaries to the current release.

@mgol
Copy link
Contributor

mgol commented Sep 7, 2015

node-sass doesn't compile for me in Node.js 4.0.0-rc.2 on OS X 10.11 (public beta 6):

$ node --version
v4.0.0-rc.2
$ npm --version
2.14.2
$ npm i node-sass
npm WARN engine [email protected]: wanted: {"node":">=0.10.0"} (current: {"node":"4.0.0-rc.2","npm":"2.14.2"})
(...)
> [email protected] install /Users/mgol/_/node_modules/node-sass
> node scripts/install.js

Cannot download "https://github.com/sass/node-sass/releases/download/v3.3.2/darwin-x64-46_binding.node": HTTP error 404 Not Found

> [email protected] postinstall /Users/mgol/_/node_modules/node-sass
> node scripts/build.js

Building: /Users/mgol/.nvm/versions/node/v4.0.0-rc.2/bin/node /Users/mgol/_/node_modules/node-sass/node_modules/pangyp/bin/node-gyp.js rebuild --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
gyp WARN install got an error, rolling back install
gyp ERR! configure error 
gyp ERR! stack Error: 404 status code downloading tarball
gyp ERR! stack     at Request.<anonymous> (/Users/mgol/_/node_modules/node-sass/node_modules/pangyp/lib/install.js:251:14)
gyp ERR! stack     at emitOne (events.js:82:20)
gyp ERR! stack     at Request.emit (events.js:169:7)
gyp ERR! stack     at Request.onRequestResponse (/Users/mgol/_/node_modules/node-sass/node_modules/pangyp/node_modules/request/request.js:1255:10)
gyp ERR! stack     at emitOne (events.js:77:13)
gyp ERR! stack     at ClientRequest.emit (events.js:169:7)
gyp ERR! stack     at HTTPParser.parserOnIncomingClient (_http_client.js:415:21)
gyp ERR! stack     at HTTPParser.parserOnHeadersComplete (_http_common.js:88:23)
gyp ERR! stack     at TLSSocket.socketOnData (_http_client.js:305:20)
gyp ERR! stack     at emitOne (events.js:77:13)
gyp ERR! System Darwin 15.0.0
gyp ERR! command "/Users/mgol/.nvm/versions/node/v4.0.0-rc.2/bin/node" "/Users/mgol/_/node_modules/node-sass/node_modules/pangyp/bin/node-gyp.js" "rebuild" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd /Users/mgol/_/node_modules/node-sass
gyp ERR! node -v v4.0.0-rc.2
gyp ERR! pangyp -v v2.3.1
gyp ERR! not ok 
Build failed
npm ERR! Darwin 15.0.0
npm ERR! argv "/Users/mgol/.nvm/versions/node/v4.0.0-rc.2/bin/node" "/Users/mgol/.nvm/versions/node/v4.0.0-rc.2/bin/npm" "i" "node-sass"
npm ERR! node v4.0.0-rc.2
npm ERR! npm  v2.14.2
npm ERR! code ELIFECYCLE

npm ERR! [email protected] postinstall: `node scripts/build.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] postinstall script 'node scripts/build.js'.
npm ERR! This is most likely a problem with the node-sass package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node scripts/build.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls node-sass
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/mgol/_/npm-debug.log

@mgol
Copy link
Contributor

mgol commented Sep 7, 2015

Ah, this is most likely due to nodejs/node-gyp#711 (comment); the fix has not been backported to pangyp yet (if ever).

@saper
Copy link
Member Author

saper commented Sep 7, 2015

Just a stupid download problem - try using --nodedir=your-node-sourcedir and it will run fine. I am using rc.1 right now for testing and it works fine.

@mgol
Copy link
Contributor

mgol commented Sep 8, 2015

You should drop pangyp in favor of node-gyp@3, it handles all these cases, including io.js & Node RCs.

https://twitter.com/rvagg/status/641045378037510144

@xzyfer
Copy link
Contributor

xzyfer commented Sep 8, 2015

It's on the road map @mzgol #1124

We adopted pangyp to get around node-gyp's lack of iojs support.

@mgol
Copy link
Contributor

mgol commented Sep 8, 2015

Oh, I missed it, sorry.

Michał Gołębiowski

@xzyfer
Copy link
Contributor

xzyfer commented Sep 8, 2015

A 3rd RC looks scheduled for release in the next 24hrs

@fhemberger
Copy link

RC5 with working node-gyp is out: https://twitter.com/rvagg/status/641163073206681600
If we don't find any mayor blocker, the final v4.0.0 will be released in a few hours.

@mgol
Copy link
Contributor

mgol commented Sep 8, 2015

The final 4.0.0 is out.

@nelsonpecora
Copy link

Hmm, I'm getting this right now. Is it looking for the wrong release?

Cannot download "https://github.com/sass/node-sass/releases/download/v3.3.2/darwin-x64-46_binding.node": HTTP error 404 Not Found

@saper
Copy link
Member Author

saper commented Sep 8, 2015 via email

@nelsonpecora
Copy link

Oh! I thought that was what @mzgol was talking about. Alright, I'll be patient. :3

@saper
Copy link
Member Author

saper commented Sep 8, 2015

But it's possible to compile it yourself, if you have a working C++11 compiler. Actually npm proceeds to the building stage after failed install.

@mgol
Copy link
Contributor

mgol commented Sep 8, 2015

@saper It doesn't compile for me on OS X 10.11 public beta 6:

$ node --version
v4.0.0
$ npm --version
2.14.2
$ npm install node-sass
npm WARN deprecated [email protected]: use node-gyp@3+, it does all the things

> [email protected] install /Users/mgol/_/node_modules/node-sass
> node scripts/install.js

Cannot download "https://github.com/sass/node-sass/releases/download/v3.3.2/darwin-x64-46_binding.node": HTTP error 404 Not Found

> [email protected] postinstall /Users/mgol/_/node_modules/node-sass
> node scripts/build.js

Building: /Users/mgol/.nvm/versions/node/v4.0.0/bin/node /Users/mgol/_/node_modules/node-sass/node_modules/pangyp/bin/node-gyp.js rebuild --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
gyp: /Users/mgol/.node-gyp/4.0.0/common.gypi not found (cwd: /Users/mgol/_/node_modules/node-sass) while reading includes of binding.gyp while trying to load binding.gyp
gyp ERR! configure error 
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/Users/mgol/_/node_modules/node-sass/node_modules/pangyp/lib/configure.js:346:16)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 15.0.0
gyp ERR! command "/Users/mgol/.nvm/versions/node/v4.0.0/bin/node" "/Users/mgol/_/node_modules/node-sass/node_modules/pangyp/bin/node-gyp.js" "rebuild" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd /Users/mgol/_/node_modules/node-sass
gyp ERR! node -v v4.0.0
gyp ERR! pangyp -v v2.3.2
gyp ERR! not ok 
Build failed
npm ERR! Darwin 15.0.0
npm ERR! argv "/Users/mgol/.nvm/versions/node/v4.0.0/bin/node" "/Users/mgol/.nvm/versions/node/v4.0.0/bin/npm" "install" "node-sass"
npm ERR! node v4.0.0
npm ERR! npm  v2.14.2
npm ERR! code ELIFECYCLE

npm ERR! [email protected] postinstall: `node scripts/build.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] postinstall script 'node scripts/build.js'.
npm ERR! This is most likely a problem with the node-sass package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node scripts/build.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls node-sass
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/mgol/_/npm-debug.log

@mattmewton
Copy link

I am having the same issue as @mzgol above on 10.10. Is there a fix coming soon for this?

@mgol
Copy link
Contributor

mgol commented Sep 8, 2015

Ahh, ignore me. I must have had a broken ~/.node-gyp, most likely because of trying experimental Node 4.0.0 binaries before. Removign that directory & running npm install node-sass again worked. :)

(I knew I should have an enough modern compiler so the issue had to be sth else...)

@saper
Copy link
Member Author

saper commented Sep 8, 2015 via email

@mgol
Copy link
Contributor

mgol commented Sep 8, 2015

I see you are running on a Mac - can you run npm test and see if you run into
#1127 ? I'd appreciate having your config.gypi

Sure. Let's move the discussion to #1127. :)

@buunguyen
Copy link

Hi, I got error installing node-sass on Node 4.0 (RTM).

> [email protected] install /Users/nn/Documents/Projects/telfi/telfi-app/node_modules/node-sass
> node scripts/install.js

Cannot download "https://github.com/sass/node-sass/releases/download/v3.3.2/darwin-x64-46_binding.node": HTTP error 404 Not Found

> [email protected] postinstall /Users/nn/Documents/Projects/telfi/telfi-app/node_modules/node-sass
> node scripts/build.js

Building: /Users/nn/.nvm/versions/node/v4.0.0/bin/node /Users/nn/Documents/Projects/telfi/telfi-app/node_modules/node-sass/node_modules/pangyp/bin/node-gyp.js rebuild --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
gyp: /Users/nn/.node-gyp/4.0.0/common.gypi not found (cwd: /Users/nn/Documents/Projects/telfi/telfi-app/node_modules/node-sass) while reading includes of binding.gyp while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/Users/nn/Documents/Projects/telfi/telfi-app/node_modules/node-sass/node_modules/pangyp/lib/configure.js:346:16)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 14.5.0
gyp ERR! command "/Users/nn/.nvm/versions/node/v4.0.0/bin/node" "/Users/nn/Documents/Projects/telfi/telfi-app/node_modules/node-sass/node_modules/pangyp/bin/node-gyp.js" "rebuild" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd /Users/nn/Documents/Projects/telfi/telfi-app/node_modules/node-sass
gyp ERR! node -v v4.0.0
gyp ERR! pangyp -v v2.3.2
gyp ERR! not ok
Build failed
npm ERR! Darwin 14.5.0
npm ERR! argv "/Users/nn/.nvm/versions/node/v4.0.0/bin/node" "/Users/nn/.nvm/versions/node/v4.0.0/bin/npm" "install" "node-sass"
npm ERR! node v4.0.0
npm ERR! npm  v2.14.2
npm ERR! code ELIFECYCLE

npm ERR! [email protected] postinstall: `node scripts/build.js`
npm ERR! Exit status 1

npm ERR! Failed at the [email protected] postinstall script 'node scripts/build.js'.
npm ERR! This is most likely a problem with the node-sass package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node scripts/build.js

@saper
Copy link
Member Author

saper commented Sep 8, 2015 via email

@buunguyen
Copy link

I did read the issue and know you don't support Node 4 yet. Just report the error I have with the RTM release and hope it helps somehow. If it doesn't, please just ignore.

@xzyfer
Copy link
Contributor

xzyfer commented Sep 8, 2015

Sounds like some of there errors are just simply due to the us not having switched back to node-gyp. Even with a 404 when downloading binaries we should be falling back to a local compilations.

@hinell
Copy link

hinell commented Sep 8, 2015

@saper Hi. How much time it takes for node 4 integration?

@saper
Copy link
Member Author

saper commented Sep 9, 2015

@hinell depends on the hourly rate offered!

@xzyfer
Copy link
Contributor

xzyfer commented Sep 9, 2015

If you use OSX you should now have Node 4 support.

@buunguyen
Copy link

@xzyfer it works, thanks a lot!

@xzyfer
Copy link
Contributor

xzyfer commented Sep 9, 2015

\o/ :tada:

@xzyfer
Copy link
Contributor

xzyfer commented Sep 9, 2015

If you use Linux you should now have Node 4 support.

@mrliptontea
Copy link

when should I expect 46 for Windows?

@xzyfer
Copy link
Contributor

xzyfer commented Sep 9, 2015

Hopefully in the next couple hours. You can always follow our Twitter for more frequent updates.

https://twitter.com/nodesass/status/641469706541604864

@darkyen
Copy link

darkyen commented Sep 9, 2015

\o/

@xzyfer
Copy link
Contributor

xzyfer commented Sep 9, 2015

If you use Window you should now have Node 4 support.

@mrliptontea
Copy link

yep, it's working 👍 🎉

@ingro
Copy link

ingro commented Sep 9, 2015

Yeah is running fine now, thanks @xzyfer !

@nelsonpecora
Copy link

@xzyfer thanks!

@yosuke-furukawa
Copy link

We are listing Node v4.0 issues in this thread. If you find any other issues, please write the issue and add the following url.
nodejs/node#2798

@xzyfer
Copy link
Contributor

xzyfer commented Sep 10, 2015

@yosuke-furukawa thanks, but we have no issues with Node v4

@xzyfer xzyfer closed this as completed Sep 10, 2015
@yosuke-furukawa
Copy link

@xzyfer perfect :)

@Master244
Copy link

Error on ubuntu 14.04 couldn't figure out if this was supported yet or not. Trying to do this in a dockerfile with an Ember project.

Step 21 : RUN npm rebuild node-sass
---> Running in 05c1efe63790

[email protected] install /src/node_modules/ember-cli-sass/node_modules/broccoli-sass-source-maps/node_modules/node-sass
node scripts/install.js

Cannot download "https://github.com/sass/node-sass/releases/download/v3.2.0/linux-x64-46_binding.node": HTTP error 404 Not Found

[email protected] postinstall /src/node_modules/ember-cli-sass/node_modules/broccoli-sass-source-maps/node_modules/node-sass
node scripts/build.js

Building: /usr/bin/nodejs node_modules/pangyp/bin/node-gyp rebuild --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
gyp: /root/.node-gyp/4.1.1/common.gypi not found (cwd: /src/node_modules/ember-cli-sass/node_modules/broccoli-sass-source-maps/node_modules/node-sass) while reading includes of binding.gyp while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: gyp failed with exit code: 1
gyp ERR! stack at ChildProcess.onCpExit (/src/node_modules/ember-cli-sass/node_modules/broccoli-sass-source-maps/node_modules/node-sass/node_modules/pangyp/lib/configure.js:345:16)
gyp ERR! stack at emitTwo (events.js:87:13)
gyp ERR! stack at ChildProcess.emit (events.js:172:7)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Linux 4.0.9-boot2docker
gyp ERR! command "/usr/bin/nodejs" "/src/node_modules/ember-cli-sass/node_modules/broccoli-sass-source-maps/node_modules/node-sass/node_modules/pangyp/bin/node-gyp" "rebuild" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd /src/node_modules/ember-cli-sass/node_modules/broccoli-sass-source-maps/node_modules/node-sass
gyp ERR! node -v v4.1.1
gyp ERR! pangyp -v v2.3.0
gyp ERR! not ok
Build failed

@saper
Copy link
Member Author

saper commented Sep 24, 2015

@Master244 Please use [email protected] since 3.2.0 does not support node 4.x. This should be the version you install by the plain npm install node-sass

faiq added a commit to faiq/scssify that referenced this issue Oct 6, 2015
If you have the lastest version of node, the install will fail. According to this  [comment] (sass/node-sass#1122 (comment)) by the package maintainer, bumping to ^3.3.3 will fix the issue.
@usta
Copy link

usta commented Oct 28, 2015

my system is trying to fetch https://github.com/sass/node-sass/releases/download/v3.4.1/linux-x64-47_binding.node
on the other hand it looks like there isn't any x86-47 How can i fix this problem

@saper
Copy link
Member Author

saper commented Oct 28, 2015 via email

@saper
Copy link
Member Author

saper commented Oct 28, 2015 via email

@usta
Copy link

usta commented Oct 28, 2015

it looks like i need compile it manually because :

gyp verb command rebuild []
gyp verb command clean []
gyp verb clean removing "build" directory
gyp verb command configure []
gyp verb check python checking for Python executable "python2" in the PATH
gyp verb which succeeded python2 /bin/python2
gyp verb check python version python2 -c "import platform; print(platform.python_version());" returned: "2.7.10\n"
gyp verb get node dir no --target version specified, falling back to host node version: 6.0.0-pre
gyp verb command install [ '6.0.0-pre' ]
gyp verb install input version string "6.0.0-pre"
gyp verb detected "pre" node version 6.0.0-pre
gyp ERR! configure error
gyp ERR! stack Error: "pre" versions of node cannot be installed, use the --nodedir flag instead
gyp ERR! stack at install (/usr/lib/node_modules/node-sass/node_modules/node-gyp/lib/install.js:64:16)
gyp ERR! stack at Object.self.commands.(anonymous function) as install
gyp ERR! stack at getNodeDir (/usr/lib/node_modules/node-sass/node_modules/node-gyp/lib/configure.js:155:20)
gyp ERR! stack at /usr/lib/node_modules/node-sass/node_modules/node-gyp/lib/configure.js:108:9
gyp ERR! stack at ChildProcess.exithandler (child_process.js:194:7)
gyp ERR! stack at emitTwo (events.js:87:13)
gyp ERR! stack at ChildProcess.emit (events.js:172:7)
gyp ERR! stack at maybeClose (internal/child_process.js:818:16)
gyp ERR! stack at Socket. (internal/child_process.js:319:11)
gyp ERR! stack at emitOne (events.js:77:13)
gyp ERR! System Linux 4.3.0-0.rc6.git2.1.fc24.x86_64
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/node-sass/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd /usr/lib/node_modules/node-sass
gyp ERR! node -v v6.0.0-pre
gyp ERR! node-gyp -v v3.0.3
gyp ERR! not ok
Build failed
npm verb lifecycle [email protected]postinstall: unsafe-perm in lifecycle false
npm verb lifecycle [email protected]
postinstall: PATH: /usr/lib/node_modules/npm/bin/node-gyp-bin:/usr/lib/node_modules/node-sass/node_modules/.bin:/usr/lib/node_modules/.bin:/sbin:/bin:/usr/sbin:/usr/bin
npm verb lifecycle [email protected]postinstall: CWD: /usr/lib/node_modules/node-sass
npm info lifecycle [email protected]
postinstall: Failed to exec postinstall script
npm verb unlock done using /root/.npm/_locks/staging-a072192f34a17023.lock for /usr/lib/node_modules/.staging
npm verb stack Error: [email protected] postinstall: node scripts/build.js
npm verb stack Exit status 1
npm verb stack at EventEmitter. (/usr/lib/node_modules/npm/lib/utils/lifecycle.js:232:16)
npm verb stack at emitTwo (events.js:87:13)
npm verb stack at EventEmitter.emit (events.js:172:7)
npm verb stack at ChildProcess. (/usr/lib/node_modules/npm/lib/utils/spawn.js:24:14)
npm verb stack at emitTwo (events.js:87:13)
npm verb stack at ChildProcess.emit (events.js:172:7)
npm verb stack at maybeClose (internal/child_process.js:818:16)
npm verb stack at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
npm verb pkgid [email protected]
npm verb cwd /home/usta/Documents/node
npm ERR! Linux 4.3.0-0.rc6.git2.1.fc24.x86_64
npm ERR! argv "/usr/bin/node" "/bin/npm" "-g" "install" "node-sass" "--verbose"
npm ERR! node v6.0.0-pre
npm ERR! npm v3.3.10
npm ERR! code ELIFECYCLE

npm ERR! [email protected] postinstall: node scripts/build.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] postinstall script 'node scripts/build.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the node-sass package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node scripts/build.js
npm ERR! You can get their info via:
npm ERR! npm owner ls node-sass
npm ERR! There is likely additional logging output above.
npm verb exit [ 1, true ]

@saper
Copy link
Member Author

saper commented Oct 28, 2015

gyp ERR! stack Error: "pre" versions of node cannot be installed, use the --nodedir flag instead

You have to do what it says: Download the source code of the node engine
you are using and use --nodedir /path/to/node/source/code flag to point it to the source.

If it doesn't work for you, just downgrade to node 4.x

You will have the same problems with all node native add-ons, not only with node-sass.

@mgol
Copy link
Contributor

mgol commented Oct 28, 2015

@saper @usta Note, thought, that this should be a problem only for manually compiled pre-releases (I suppose that's the case here). Compiling alphas, rcs etc. should work with newest node-gyp but doesn't for some reason, I reported it in #1224. Other native packages seem to be fine, only node-sass has problems here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests