Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update remark-preset-lint-node to 1.7.0 #28393

Merged
merged 0 commits into from
Jun 27, 2019
Merged

tools: update remark-preset-lint-node to 1.7.0 #28393

merged 0 commits into from
Jun 27, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 23, 2019

This update enables linting for "note that" in our docs. That phrase is
almost always superfluous. Sentences are almost always clearer and
stronger without it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 23, 2019
@Trott
Copy link
Member Author

Trott commented Jun 23, 2019

LIte CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3704/

@Trott
Copy link
Member Author

Trott commented Jun 26, 2019

/ping @nodejs/linting

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 26, 2019
@Trott
Copy link
Member Author

Trott commented Jun 26, 2019

A note on landing this, in case someone other than me does it: Be sure to run make lint-md before pushing the commit to upstream. It's possible that some violations of the newly-added lint constraint have been committed since this was opened. Probably not, but if so, those will need to be fixed while landing this.

@Trott Trott closed this Jun 27, 2019
@Trott Trott deleted the update-note-that branch June 27, 2019 04:21
@Trott
Copy link
Member Author

Trott commented Jun 27, 2019

Landed in cf9a7f2

@Trott Trott merged commit cf9a7f2 into nodejs:master Jun 27, 2019
targos pushed a commit that referenced this pull request Jul 2, 2019
@Trott @targos
tools: update remark-preset-lint-node to 1.7.0
03e3ccd 
This update enables linting for "note that" in our docs. That phrase is
almost always superfluous. Sentences are almost always clearer and
stronger without it.

PR-URL: #28393
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watilde watilde watilde approved these changes

@richardlau richardlau richardlau approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @watilde @richardlau @trivikr @nodejs-github-bot