chore: update AUTHORS list #34694
chore: update AUTHORS list #34694
Conversation
nodejs-github-bot
added
the
meta
AUTHORS
Outdated
| ExE Boss <[email protected]> | ||
| Mateusz Krawczuk <[email protected]> | ||
| Jonathan MERCIER <[email protected]> | ||
| Ujjwal Sharma <[email protected]> |
There was a problem hiding this comment.
This is definitely a duplicate. Please remove it and update .mailmap. Did you check if there are more?
There was a problem hiding this comment.
@lpinca This email is also not present in .mailmap should I update it in the .mailmap as well?
There was a problem hiding this comment.
Yes, add it here
Line 414 in dd0c522
There was a problem hiding this comment.
I think the update-authors also need to change for this.
|
This could be automated by an Action. Any takers? |
|
@mmarchini I just used the script in the tools, will try to update the script so that this case doesn't occur and update the AUTHORS file. |
|
@yashLadha might be better to do @lpinca suggestion above for this PR and then open another one for changes on the script. |
AUTHORS
Outdated
| Alex R <[email protected]> | ||
| Hachimi Aa (Sfeir) <[email protected]> | ||
| Daniel Estiven Rico Posada <[email protected]> | ||
| Ruben Bridgewater <[email protected]> |
There was a problem hiding this comment.
You also need to add this email address to the .mailmap, otherwise it will show up again during the next update
|
Okay @mmarchini Will remove the duplicates. |
| Bartlomiej Brzozowski <[email protected]> | ||
| Saajan <[email protected]> | ||
| Yash Ladha <[email protected]> | ||
| Xu Meng <[email protected]> |
| Kirill Shatskiy <[email protected]> | ||
| Ben Bucksch <[email protected]> | ||
| Eli Schwartz <[email protected]> | ||
| Ash Cripps <[email protected]> |
| Johannes Schöpp <[email protected]> | ||
| Francisco Ryan Tolmasky I <[email protected]> | ||
| Ye-hyoung Kang <[email protected]> | ||
| Myles Borins <[email protected]> |
|
I'm closing this as it was superseded by #35280. |
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes