Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update AUTHORS list #35280

Closed
wants to merge 2 commits into from
Closed

doc: update AUTHORS list #35280

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

Checklist

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 21, 2020
addaleax
addaleax commented Sep 21, 2020
View reviewed changes
.mailmap
@@ -324,6 +325,7 @@ Roman Reiss <[email protected]>
Ron Korving <[email protected]> <[email protected]>
Ron Korving <[email protected]> ronkorving <[email protected]>
Ruben Bridgewater <[email protected]> <[email protected]>
Ruben Bridgewater <[email protected]> <[email protected]>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BridgeAR Is this still the address you prefer?

addaleax
addaleax commented Sep 21, 2020
View reviewed changes
.mailmap Show resolved Hide resolved
@richardlau
Copy link
Member

FWIW there were some duplicates identified in #34694 that still apply.

addaleax
addaleax commented Sep 21, 2020
View reviewed changes
AUTHORS Outdated Show resolved Hide resolved
addaleax
addaleax commented Sep 21, 2020
View reviewed changes
AUTHORS
Bartlomiej Brzozowski <[email protected]>
Saajan <[email protected]>
Yash Ladha <[email protected]>
Xu Meng <[email protected]>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmabupt Which is your preferred address?

mhdawson
mhdawson approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott
Trott approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33369/

MylesBorins
MylesBorins approved these changes Oct 5, 2020
View reviewed changes
.mailmap
Comment on lines +286 to +288
Myles Borins <[email protected]> <[email protected]>
Myles Borins <[email protected]> <[email protected]>
Myles Borins <[email protected]> <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It me!

TYVM

@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2020

Landed in dd571ca

@github-actions github-actions bot closed this Oct 5, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 5, 2020
@addaleax @nodejs-github-bot
doc: update AUTHORS list
dd571ca 
PR-URL: #35280
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@lpinca lpinca mentioned this pull request Oct 5, 2020
Closed
4 tasks
@danielleadams danielleadams mentioned this pull request Oct 6, 2020
Merged
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@addaleax @danielleadams
doc: update AUTHORS list
f08577c 
PR-URL: #35280
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@addaleax @MylesBorins
doc: update AUTHORS list
8d4b0c3 
PR-URL: #35280
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@addaleax @MylesBorins
doc: update AUTHORS list
b5f7525 
PR-URL: #35280
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@addaleax @joesepi
doc: update AUTHORS list
6c750e5 
PR-URL: nodejs#35280
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nibbler999 Nibbler999 Nibbler999 left review comments

@MylesBorins MylesBorins MylesBorins approved these changes

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@watilde watilde watilde approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@mhdawson mhdawson mhdawson approved these changes

@crypt096 crypt096 crypt096 approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.