-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V14.12.0 proposal #35285
V14.12.0 proposal #35285
Commits on Sep 17, 2020
-
doc: use correct Error type for EventEmitter.defaultMaxListener
If a bad value is assigned to EventEmitter.defaultMaxListener, a RangeError is thrown and not a TypeError. Update documentation to reflect this. PR-URL: #35069 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fb89be6 - Browse repository at this point
Copy the full SHA fb89be6View commit details -
test: add more valid results to test-trace-atomics-wait
The two starting `Atomics.wait()` operations are not ordered, but the test assumed a specific ordering because of the latency that comes with spinning up a Worker thread. Add variants of the existing potential valid results that account for the reverse ordering. Fixes: #35059 PR-URL: #35066 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 25f93f3 - Browse repository at this point
Copy the full SHA 25f93f3View commit details -
Revert "build: require "allow edits" to be checked"
This reverts commit 07423b5. Refs: #35002 (comment) PR-URL: #35094 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f3c45a1 - Browse repository at this point
Copy the full SHA f3c45a1View commit details -
test: separate the test fixtures between ICU and URL
We need to emit dependency of ICU's toASCII in order to update the WPT fixtures. Since ICU and URL isn't the same implementation and they also follow different specifications. ICU's toASCII shouldn't have a dependency on WPT fixtures. Refs: #33770 (comment) PR-URL: #35077 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9faaa65 - Browse repository at this point
Copy the full SHA 9faaa65View commit details -
doc: make minor improvements to module.md
* sort references in ASCII order * replace abbreviation * split comma splice into two sentences and add appropriate punctuation * replace future tense with present tense PR-URL: #35083 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1cf9934 - Browse repository at this point
Copy the full SHA 1cf9934View commit details -
test: fix comment about DNS lookup test
PR-URL: #35080 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bc38485 - Browse repository at this point
Copy the full SHA bc38485View commit details -
crypto: improve randomInt out-of-range error message
Previously, the crypto.randomInt() message when "max" was less than or equal to "min" made it sound like the lower bound for "max" was hard-coded. Make it clear that it is instead dynamic based on the value of "min". For crypto.randomInt(10,0): Before: RangeError [ERR_OUT_OF_RANGE]: The value of "max" is out of range. It must be > 10. Received 0 After: RangeError [ERR_OUT_OF_RANGE]: The value of "max" is out of range. It must be greater than the value of "min" (10). Received 0 PR-URL: #35088 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3573545 - Browse repository at this point
Copy the full SHA 3573545View commit details -
crypto: improve invalid arg type message for randomInt()
Use "must be a safe integer" rather than "must be safe integer". I believe the former is more easily understood/clear. PR-URL: #35089 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1bb0ed3 - Browse repository at this point
Copy the full SHA 1bb0ed3View commit details -
test: remove setMaxListeners in test-crypto-random
This appears to be a remnant from 413d38c. PR-URL: #35079 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6627c1f - Browse repository at this point
Copy the full SHA 6627c1fView commit details -
doc: avoid double-while sentence in perf_hooks.md
This improves readability, as well as awkward reptition of the word _while_ with two different meanings in a single sentence. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/w/while PR-URL: #35078 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0a2610a - Browse repository at this point
Copy the full SHA 0a2610aView commit details -
doc: add note about path.basename on Windows
PR-URL: #35065 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 93e4d54 - Browse repository at this point
Copy the full SHA 93e4d54View commit details -
test: revise test-policy-integrity
* eliminate unneeded Set deletion/cleanup * use number of CPUs as limit for processes spawned rather than hard-coding the limit PR-URL: #35101 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 379c5ce - Browse repository at this point
Copy the full SHA 379c5ceView commit details -
module: fix specifier resolution option value
Fixes: #35095 PR-URL: #35098 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 314483c - Browse repository at this point
Copy the full SHA 314483cView commit details -
doc: fix broken links in deprecations.md
PR-URL: #35109 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 79c6d92 - Browse repository at this point
Copy the full SHA 79c6d92View commit details -
PR-URL: #35111 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f4e958f - Browse repository at this point
Copy the full SHA f4e958fView commit details -
doc: fix broken link in http2.md
PR-URL: #35112 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5c8d208 - Browse repository at this point
Copy the full SHA 5c8d208View commit details -
doc: fix broken link in perf_hooks.md
PR-URL: #35113 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aa93c1c - Browse repository at this point
Copy the full SHA aa93c1cView commit details -
doc,test: specify and test CLI option precedence rules
Refs: #35098 (comment) PR-URL: #35106 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b75822d - Browse repository at this point
Copy the full SHA b75822dView commit details -
esm: better package.json parser errors
PR-URL: #35117 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6e622d6 - Browse repository at this point
Copy the full SHA 6e622d6View commit details -
- update security process to reflect current way to request tweet/retweet of security release Signed-off-by: Michael Dawson <[email protected]> PR-URL: #35107 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 122edad - Browse repository at this point
Copy the full SHA 122edadView commit details -
Notable changes: - Several issues have been addressed in uvwasi_fd_readdir(). A bug in the copying of the directory entry's name has been fixed. The function now returns UVWASI_ENOSYS on Windows and Android. Serdes support has been added for uvwasi_dirent_t's. - The libuv dependency has been updated to v1.39.0. PR-URL: #35104 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d4389b5 - Browse repository at this point
Copy the full SHA d4389b5View commit details -
doc: add missing changes entry for breakEvalOnSigint REPL option
PR-URL: #35143 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 46b9f4b - Browse repository at this point
Copy the full SHA 46b9f4bView commit details -
Update email address to reflect move to Red Hat Signed-off-by: Michael Dawson <[email protected]> PR-URL: #35121 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f4e714a - Browse repository at this point
Copy the full SHA f4e714aView commit details -
errors: simplify ERR_REQUIRE_ESM message generation
Because of the condition that starts the `if` block, we know that `parentPath` must be truthy. So there is no need to check for that in the template string that generates the error message. PR-URL: #35123 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4bde865 - Browse repository at this point
Copy the full SHA 4bde865View commit details -
doc: simplify circular dependencies text in modules.md
PR-URL: #35126 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for df70861 - Browse repository at this point
Copy the full SHA df70861View commit details -
http: allow Content-Length header for 304 responses
Fixes: #31037 PR-URL: #34835 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 977b0ed - Browse repository at this point
Copy the full SHA 977b0edView commit details -
PR-URL: #35160 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f21a5c6 - Browse repository at this point
Copy the full SHA f21a5c6View commit details -
buffer: adjust validation to account for buffer.kMaxLength
PR-URL: #35134 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5229ffa - Browse repository at this point
Copy the full SHA 5229ffaView commit details -
http: only set keep-alive when not exists
PR-URL: #35138 Fixes: #34561 Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8ea2853 - Browse repository at this point
Copy the full SHA 8ea2853View commit details -
doc: update contact info for Ash Cripps
PR-URL: #35139 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 331142c - Browse repository at this point
Copy the full SHA 331142cView commit details -
doc: fix left nav color contrast
I believe this is the last change to make in the docs for color contrast accessibility per WCAG AA. Currently, the current item in the nav is #43853d on a #333333 background for a color contrast of 2.8:1, failing WCAG AA. This swaps in removes a confusing bottom border on the item, replacing it with bolding to preserve the item's highlighting. PR-URL: #35141 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7dbcd24 - Browse repository at this point
Copy the full SHA 7dbcd24View commit details -
doc: improve table accessibility
The compatibility matrix in the N-API doc needs row headers for accessibility purposes. Unfortunately, those aren't possible in markdown without resorting to HTML markup. So this converts the table from markdown to HTML. This is less convenient for documentation authors and for other readers of the raw markdown docs, but I believe accessibility for the viewers of our HTML docs outweighs that concern. PR-URL: #35146 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e410514 - Browse repository at this point
Copy the full SHA e410514View commit details -
doc: perform minor cleanup on cli.md
* sort references in ASCII order * merge logically-connected single-sentence paragraphs * remove _please_ from referrals to other docs * remove unnecessary italics * make some text more concise * change some instances of future tense to present tense PR-URL: #35152 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ae85228 - Browse repository at this point
Copy the full SHA ae85228View commit details -
meta: add links to OpenJSF Slack
The OpenJS Foundation has an official Slack, and the Node.js project has many channels there for working groups as well as for general discussions. Add links to the workspace and channels for folks who want to join. PR-URL: #35128 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 12f2934 - Browse repository at this point
Copy the full SHA 12f2934View commit details -
doc: fix minor punctuation issue in path.md
PR-URL: #35127 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 99785e4 - Browse repository at this point
Copy the full SHA 99785e4View commit details -
build: filter issues & PRs to auto close by matching on stalled label
The auto closing of issues & PRs labelled with `stalled` doesn't seem to be working as expected. The GitHub Action UI gives the impression the stale action tries to execute more operations than it is allowed to do. Previously there was no filtering on issues & PRs. So when it tries to fetch all the currently open issues, checking whether or not they should be get closed, it would have to perform quite a few requests pagination requests to get the information needed. Knowing that we only care about issues & PRs already labelled `stalled`, we can provide the [`only-labels`](https://github.com/actions/stale/blob/13b324e4b28a2708236aadb11361fa65af60d201/action.yml#L38) option to make sure we only fetch relevant issues. Refs #35144 PR-URL: #35159 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f2cc1c2 - Browse repository at this point
Copy the full SHA f2cc1c2View commit details -
doc: perform cleanup on security-release-process.md
These are exceedingly minor, but I'm doing them anyway for consistency across our docs (whether internal process docs or user-facing docs). * ASCII order for references * Minor punctuation adjustments * Use product capitalization for Twitter and Slack * Sentence-case for header PR-URL: #35154 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e8d479e - Browse repository at this point
Copy the full SHA e8d479eView commit details -
doc: add missing copyFile change history
PR-URL: #35056 Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dc4c569 - Browse repository at this point
Copy the full SHA dc4c569View commit details -
doc: fix broken links in modules.md
PR-URL: #35182 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 176e9e4 - Browse repository at this point
Copy the full SHA 176e9e4View commit details -
`process.release` documentation is out of date. This commit makes it up to date. PR-URL: #35167 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 32d1731 - Browse repository at this point
Copy the full SHA 32d1731View commit details -
doc: update eventLoopUtilization documentation
PR-URL: #35155 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aea3f77 - Browse repository at this point
Copy the full SHA aea3f77View commit details -
Update ESLint to 7.9.0 PR-URL: #35170 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0a97f44 - Browse repository at this point
Copy the full SHA 0a97f44View commit details
Commits on Sep 21, 2020
-
doc: remove problematic auto-linking of curl man pages
The only instance of curl man page linking is in repl.md and it is explicit. The magic autolinking in html.js creates a superfluous empty link. Remove it. Before, two adjacent links generated, with the first one having no text: ```html <a href="https://curl.haxx.se/docs/manpage.html"></a> <a href="https://curl.haxx.se/docs/manpage.html"><code>curl(1)</code></a> ``` After, just one link: ```html <a href="https://curl.haxx.se/docs/manpage.html"><code>curl(1)</code></a> ``` PR-URL: #35174 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Coe <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 066148d - Browse repository at this point
Copy the full SHA 066148dView commit details -
test: improve pummel/test-timers.js
* use Date.now() instead of new Date() because only the timestamp is ever used, so we don't need the full Date object * use separate start times recorded for the two different test cases * improve assertion messages PR-URL: #35175 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 49da459 - Browse repository at this point
Copy the full SHA 49da459View commit details -
module: use isURLInstance instead of instanceof
PR-URL: #34951 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 76e24f9 - Browse repository at this point
Copy the full SHA 76e24f9View commit details -
fs: loosen validation to allow objects with an own toString function
PR-URL: #34993 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for beb75bd - Browse repository at this point
Copy the full SHA beb75bdView commit details -
doc: fix broken link in crypto.md
URL that lacks a scheme gets treated as a relative URL. Add missing `https://`. PR-URL: #35181 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 910deff - Browse repository at this point
Copy the full SHA 910deffView commit details -
doc: fix deprecation documentation inconsistencies
PR-URL: #35082 Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c1e16d1 - Browse repository at this point
Copy the full SHA c1e16d1View commit details -
doc: fix missing word in dgram.md
The word "cannot" is missing from this sentence PR-URL: #35231 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e5fffe2 - Browse repository at this point
Copy the full SHA e5fffe2View commit details -
doc: replace "you should do X" with "do X"
PR-URL: #35194 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 70ec369 - Browse repository at this point
Copy the full SHA 70ec369View commit details -
doc: use command-line/command line consistently
Docs switch between "command line" and "command-line" with no apparent uniformity. Microsoft Style Guide prescribes "command line" as a noun and "command-line" as a modifier, which makes a lot of sense to me. Updating docs as appropriate. PR-URL: #35198 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c1c93a6 - Browse repository at this point
Copy the full SHA c1c93a6View commit details -
We use "end user" in ambiguous ways. Sometimes we mean the developer, and sometimes we mean the application user. Use "developer" where developer is meant. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/u/user-end-user PR-URL: #35200 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dbfd3b2 - Browse repository at this point
Copy the full SHA dbfd3b2View commit details -
doc: add technical values document
As part of the [next-10](https://github.com/nodejs/next-10) we found we needed to capture the project's technical values/priorities as a starting point before discussing key technologies/areas for the next 10 years of Node.js This is a first cut that the team put together. The discussion took place in a few meetings as well as this [PR](nodejs/next-10#11). We believe the doc should live in the core node repository as it is intended to reflect the agreement of the collaborator base. I think this is a good starting point but we also acknowledge that only a small subset of the Node.js collaborators have participated/commented so far. This PR should be a good way to get additional review/input from the larger set of Node.js collaborators. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #35145 Reviewed-By: Christopher Hiller <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Ben Coe <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 92a14d3 - Browse repository at this point
Copy the full SHA 92a14d3View commit details -
build: increase API requests for stale action
The second attempt at getting the auto closing of issues & PRs to work as expected without hitting a maximum operations allowed error we've been seeing. Recently discovered that the mentioned error is actually self imposed by the stale action itself. It keeps track of how many outgoing GitHub API requests it performs, and if that count exceeds the configured `operations-per-run` option, it exits to avoid hitting API rate limits. Default `operations-per-run` value is set to `30`. That's a very low limit and we're not at all concerned hitting that rate limit as of now, so we're bumping `operations-per-run` to `500` with these changes. Refs #35144 PR-URL: #35235 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3d78686 - Browse repository at this point
Copy the full SHA 3d78686View commit details -
This commit provides coverage for __wasi_fd_readdir(). PR-URL: #35202 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8357b56 - Browse repository at this point
Copy the full SHA 8357b56View commit details -
doc: fix small grammatical issues in timers.md
PR-URL: #35203 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 64ac5c6 - Browse repository at this point
Copy the full SHA 64ac5c6View commit details -
n-api: add more property defaults
Add a default value for class method and js like property in enum napi_property_attributes. n-api currently offers only one default which is non configurable, non writable, non enumerable - like Object.defineProperty(). While this is formal correct the usual way to create properties in JS is either by defining a class or use obj.prop = value. The defaults from these variants are now backed into enum values. PR-URL: #35214 Refs: nodejs/node-addon-api#811 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7f3b2b2 - Browse repository at this point
Copy the full SHA 7f3b2b2View commit details -
doc: fix header level for error code
PR-URL: #35219 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2308be0 - Browse repository at this point
Copy the full SHA 2308be0View commit details -
doc: add issue labels sections to release guide
PR-URL: #35224 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7610fe5 - Browse repository at this point
Copy the full SHA 7610fe5View commit details -
doc: update attributes used by n-api samples (#35220)
Update n-api samples to create object properties matching to the JS defaults. Using non configurable, non writable properties has its usecases but the JS default for class methods is `configurable` and `writable`. Js properties set by JS code `obj.prop = val` are `configurable`, `writable` and `enumerable`.
Configuration menu - View commit details
-
Copy full SHA for 6d4ab36 - Browse repository at this point
Copy the full SHA 6d4ab36View commit details -
doc: clarify use of NAPI_EXPERIMENTAL
We've had a few questions about APIs not being available which were related to not having specified `NAPI_EXPERIMENTAL`. Add some additional documentation to explain this common issue: Refs: nodejs/node-addon-api#810 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #35195 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6119e95 - Browse repository at this point
Copy the full SHA 6119e95View commit details -
Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as stable. Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #35199 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ca11816 - Browse repository at this point
Copy the full SHA ca11816View commit details -
doc: relax prohibition on personal pronouns
Our personal pronoun prohibition is contrary to most current technical documentation style guides. The prohibition on personal pronouns comes from academic style guides. It results in an unnecessary formal tone. It encourages wordiness and the overuse of passive voice. This change to our style guide more closely aligns us with the style guides of companies like Google, IBM, and Microsoft. Google's style guide suggests avoiding first-person pronouns and suggests: "Use the second-person pronoun (_you_) whenever possible." Refs: https://developers.google.com/style/pronouns#personal-pronouns IBM's style guide also recommends second-person voice ("Use second person ('you')"). Refs: https://www.ibm.com/developerworks/library/styleguidelines/index.html Similarly, Microsoft's style guide recommends using first person sparingly and avoiding first-person plural. "In general, use second person". Refs: https://docs.microsoft.com/en-us/style-guide/grammar/person#in-general-use-second-person PR-URL: #34353 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d195d20 - Browse repository at this point
Copy the full SHA d195d20View commit details -
doc: sort repl references in ASCII order
PR-URL: #35230 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b9161f4 - Browse repository at this point
Copy the full SHA b9161f4View commit details -
doc: remove excessive formatting in dgram.md
PR-URL: #35234 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b62d9b4 - Browse repository at this point
Copy the full SHA b62d9b4View commit details -
doc: clarify napi_property_attributes text
* Rearrange sentence to avoid ambiguity whether the entire sentence applies to a method in a JS class or just the "but not" part * Use serial comma * Correct spelling of _configurable_ PR-URL: #35253 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2bc335d - Browse repository at this point
Copy the full SHA 2bc335dView commit details -
test: improve assertions in pummel/test-timers
* Timers should not fire early. Check for that. * Allow the wiggle-room to increase on subsequent iterations of intervals. PR-URL: #35216 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e29e2da - Browse repository at this point
Copy the full SHA e29e2daView commit details -
doc: revise stability section of values doc
Make the section a bit shorter and comply with minor elements of Microsoft Style Guide. PR-URL: #35242 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d82dd0c - Browse repository at this point
Copy the full SHA d82dd0cView commit details -
doc: standardize on _backward_
We use _backward incompatible_ and _backwards incompatible_ with no discernible pattern in the docs. Follow Chicago Manual of Style and also our standardization on US English and favor _backward_. PR-URL: #35243 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b860a7f - Browse repository at this point
Copy the full SHA b860a7fView commit details -
readline: fix key name for function keys with modifiers
Fixes: #35251 PR-URL: #35268 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4f4faa8 - Browse repository at this point
Copy the full SHA 4f4faa8View commit details -
https: set requestTimeout default to 0
Fixes: #35261 PR-URL: #35264 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d8b5714 - Browse repository at this point
Copy the full SHA d8b5714View commit details
Commits on Sep 22, 2020
-
doc: use present tense in error messages
Error messages are a mix of present and past tense. They should be mostly or entirely present tense. This eliminates the past tense constructions "was found" and "were found". Backport-PR-URL: #35247 PR-URL: #35164 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 836680a - Browse repository at this point
Copy the full SHA 836680aView commit details -
Configuration menu - View commit details
-
Copy full SHA for efd5c83 - Browse repository at this point
Copy the full SHA efd5c83View commit details