stdio: lazy read ReadStream #36823
Closed
stdio: lazy read ReadStream #36823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This supersedes #36277 |
All stdio ReadStream's use manual start to avoid consuming data for example when a process execs/spawns. Using stream._construct would cause the Readable to incorrectly greedily start reading. Refs: nodejs#36251
ronag
added
request-ci
|
@nodejs/streams |
github-actions
bot
removed
the
request-ci
|
This is not a PR targeting v15.x, so I've removed the label. |
ronag
added
review wanted
benjamingr
approved these changes
Jan 10, 2021
ronag
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/36823 ✔ Done loading data for nodejs/node/pull/36823 ----------------------------------- PR info ------------------------------------ Title stdio: lazy read ReadStream (#36823) Author Robert Nagy (@ronag) Branch ronag:stdin-lazy -> nodejs:master Labels author ready, stream Commits 2 - stdio: lazy read ReadStream - fixup: use needReadable Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/36823 Refs: https://github.com/nodejs/node/issues/36251 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36823 Refs: https://github.com/nodejs/node/issues/36251 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-01-06T23:06:21Z: https://ci.nodejs.org/job/node-test-pull-request/35342/ - Querying data for job/node-test-pull-request/35342/ ✔ Build data downloaded - Querying failures of job/node-test-commit/43421/ ✔ Data downloaded ✖ 6 failure(s) on the last Jenkins CI run ℹ This PR was created on Wed, 06 Jan 2021 22:24:11 GMT ✔ Approvals: 2 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/36823#pullrequestreview-563341020 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/36823#pullrequestreview-564867931 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/475761868 |
ronag
pushed a commit
that referenced
this pull request
Jan 10, 2021
Using stream._construct would cause the Readable to incorrectly greedily start reading. Fixes: #36251 PR-URL: #36823 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
|
Landed in 053abac |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Using stream._construct would cause the Readable to incorrectly greedily start reading. Fixes: #36251 PR-URL: #36823 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
3 tasks
targos
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All stdio ReadStream's use manual start to avoid
consuming data for example when a process
execs/spawns.
Using stream._construct would cause the Readable
to incorrectly greedily start reading.
Refs: #36251