Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdio: lazy read ReadStream #36823

Closed
wants to merge 2 commits into from
Closed

stdio: lazy read ReadStream #36823

wants to merge 2 commits into from

Commits on Jan 6, 2021

  1. stdio: lazy read ReadStream 

    All stdio ReadStream's use manual start to avoid
consuming data for example when a process
execs/spawns.

Using stream._construct would cause the Readable
to incorrectly greedily start reading.

Refs: nodejs#36251
    @mmomtchev @ronag
    mmomtchev authored and ronag committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    e8517c2 View commit details
    Browse the repository at this point in the history

  2. fixup: use needReadable

    @ronag
    ronag committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    c47d895 View commit details
    Browse the repository at this point in the history