tls: fix session and keylog add listener segfault #38180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Linkgoron
force-pushed
the
tls-fix-call-after-destroy
branch
3 times, most recently
from
80f37a5
to
68d7662
Compare
Fix an issue where adding a session or keylog listener on a tlsSocket after it was destroyed caused a segfault. fixes: nodejs#38133 fixes: nodejs#38135
Linkgoron
force-pushed
the
tls-fix-call-after-destroy
branch
from
68d7662
to
581c0be
Compare
jasnell
approved these changes
Apr 9, 2021
lpinca
reviewed
Apr 10, 2021
lpinca
approved these changes
Apr 10, 2021
Linkgoron
added
the
author ready
|
Landed in 3da003c |
jasnell
pushed a commit
that referenced
this pull request
Apr 12, 2021
Fix an issue where adding a session or keylog listener on a tlsSocket after it was destroyed caused a segfault. fixes: #38133 fixes: #38135 PR-URL: #38180 Fixes: #38133 Fixes: #38135 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 15, 2021
Fix an issue where adding a session or keylog listener on a tlsSocket after it was destroyed caused a segfault. fixes: #38133 fixes: #38135 PR-URL: #38180 Fixes: #38133 Fixes: #38135 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
Fix an issue where adding a session or keylog listener on a tlsSocket after it was destroyed caused a segfault. fixes: #38133 fixes: #38135 PR-URL: #38180 Fixes: #38133 Fixes: #38135 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Fix an issue where adding a session or keylog listener on a tlsSocket after it was destroyed caused a segfault. fixes: #38133 fixes: #38135 PR-URL: #38180 Fixes: #38133 Fixes: #38135 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Fix an issue where adding a session or keylog listener on a tlsSocket after it was destroyed caused a segfault. fixes: #38133 fixes: #38135 PR-URL: #38180 Fixes: #38133 Fixes: #38135 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where adding a
sessionorkeyloglistener on a tlsSocket after it was destroyed causes a segfault.fixes: #38133
fixes: #38135