bootstrap: do not generate code cache in an unfinalized isolate #49108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
joyeecheung
force-pushed
the
unfinalized-isolate
branch
2 times, most recently
from
d480c3a
to
2537a87
Compare
benjamingr
approved these changes
Aug 11, 2023
This was referenced Aug 13, 2023
github-actions
bot
removed
the
request-ci
anonrig
approved these changes
Aug 15, 2023
V8 now no longer supports serializing code cache in an isolate with unfinalized read-only space. So guard the code cache regeneration with the `is_building_snapshot()` flag. When the isolate is created for snapshot generation, the code cache is going to be serialized separately anyway, so there is no need to do it in the builtin loader.
joyeecheung
force-pushed
the
unfinalized-isolate
branch
from
2537a87
to
c35a69a
Compare
|
Rebased because the GitHub CI doesn't rebase to pick up #49110... |
github-actions
bot
removed
the
request-ci
|
Rebased to resolve conflicts.. |
github-actions
bot
removed
the
request-ci
anonrig
approved these changes
Aug 16, 2023
26 tasks
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in fe219e0 |
This was referenced Aug 18, 2023
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
V8 now no longer supports serializing code cache in an isolate with unfinalized read-only space. So guard the code cache regeneration with the `is_building_snapshot()` flag. When the isolate is created for snapshot generation, the code cache is going to be serialized separately anyway, so there is no need to do it in the builtin loader. PR-URL: #49108 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 now no longer supports serializing code cache in an isolate with unfinalized read-only space. So guard the code cache regeneration with the
is_building_snapshot()flag. When the isolate is created for snapshot generation, the code cache is going to be serialized separately anyway, so there is no need to do it in the builtin loader.