Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: do not generate code cache in an unfinalized isolate #49108

Merged
merged 1 commit into from
Aug 17, 2023
Merged

bootstrap: do not generate code cache in an unfinalized isolate #49108

merged 1 commit into from
Aug 17, 2023

Commits on Aug 15, 2023

  1. bootstrap: do not generate code cache in an unfinalized isolate 

    V8 now no longer supports serializing code cache in an isolate
with unfinalized read-only space. So guard the code cache regeneration
with the `is_building_snapshot()` flag. When the isolate is created
for snapshot generation, the code cache is going to be serialized
separately anyway, so there is no need to do it in the builtin loader.
    @joyeecheung
    joyeecheung committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    c35a69a View commit details
    Browse the repository at this point in the history