deps: update libuv to 1.47.0 #50650

nodejs-github-bot · 2023-11-10T08:44:05Z

This is an automated update of libuv to 1.47.0.

deps/uv/configure.ac

nodejs-github-bot · 2023-11-10T15:48:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55536/

bnoordhuis · 2023-11-10T21:22:58Z

The AIX build failure is libuv/libuv#4117, cc @nodejs/platform-aix

nodejs-github-bot · 2023-11-11T06:12:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55549/

abmusse · 2023-11-13T16:12:16Z

The AIX build failure is libuv/libuv#4117, cc @nodejs/platform-aix

Hey @bnoordhuis I'm looking to getting this resolved for AIX

Update: created a wip pr

libuv/libuv#4222

aix does not implement ifaddrs and when retrieving the network interfaces with uv_interface_addresses there was a test failure in tcp_connect6_link_local. Ref: libuv#4222 (comment) For now disable ipv6 link local to: 1) fix broken aix build 2) stop blocking libuv upgrade in node Ref: nodejs/node#50650

aix does not implement ifaddrs and when retrieving the network interfaces with uv_interface_addresses there was a test failure in tcp_connect6_link_local. Ref: libuv#4222 (comment) For now disable ipv6 link local on aix to: 1) fix broken aix build 2) stop blocking libuv upgrade in node Ref: nodejs/node#50650

AIX does not implement ifaddrs and when retrieving the network interfaces with uv_interface_addresses there was a test failure in tcp_connect6_link_local. For now disable ipv6 link local on aix to: 1) fix broken aix build 2) stop blocking libuv upgrade in node Refs: #4222 (comment) Refs: nodejs/node#50650

AlttiRi · 2023-11-19T07:39:23Z

So, this PR was not merged due to this bug libuv/libuv#4213, but obviously that fix will be included only in the next libuv release ...in a half of a year, or even more?

Are you really think that this bug is not important? #48673
Is it OK to break applications which work with user files?

richardlau · 2023-11-21T15:45:40Z

The AIX build failure is libuv/libuv#4117, cc @nodejs/platform-aix

Hey @bnoordhuis I'm looking to getting this resolved for AIX

Update: created a wip pr

libuv/libuv#4222

Quick update since @abmusse is on vacation this week. We ran into some issues with libuv/libuv#4222 which will need more time to investigate. In the meantime we fixed the compile failure on AIX by reverting parts of libuv/libuv#4107 on AIX/IBM i only in libuv/libuv#4229.

rvagg · 2023-11-29T03:10:58Z

libuv/libuv#4092 is a pretty big deal for Windows users and it's been quite a long time in the queue, (I've personally been watching daily CI failures from this one for months now). This has been broken since v20.4.0 (2023-07-05). If we can avoid having AIX hold up Windows fixes that would be awesome.

richardlau · 2023-11-29T03:14:35Z

libuv/libuv#4092 is a pretty big deal for Windows users and it's been quite a long time in the queue, (I've personally been watching daily CI failures from this one for months now). This has been broken since v20.4.0 (2023-07-05). If we can avoid having AIX hold up Windows fixes that would be awesome.

@abmusse fixed the AIX builds over a week ago in libuv in libuv/libuv#4229. If no new libuv version is forthcoming we could cherry-pick that here temporarily.

deps: update libuv to 1.47.0 PR-URL: #50650 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Original commit message: aix: disable ipv6 link local (#4229) AIX does not implement ifaddrs and when retrieving the network interfaces with uv_interface_addresses there was a test failure in tcp_connect6_link_local. For now disable ipv6 link local on aix to: 1) fix broken aix build 2) stop blocking libuv upgrade in node Refs: libuv/libuv#4222 (comment) Refs: #50650 Refs: libuv/libuv@bfbe4e3 PR-URL: #50650 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Rush · 2023-12-29T20:12:44Z

Can this be backported to 20 LTS? #50717

We updated from Ubuntu 20.04 LTS to 22.04 LTS which started triggering io uring bugs in libuv 1.45.

AlttiRi · 2023-12-29T23:50:52Z

They still not released 20.12.0 LTS (a pair release of 21.5.0). And will not do it until holidays (?) end.
#51124 (comment)

Based on their release approach, the fix will be landed only in the next version, after 20.12.0 LTS, in 20.13.0 / 20.12.1.

Now the fix is only in 21.5.0 Current.

As I see, the main difference between LTS and Current is that updates go to Current first, and only after one release they are added to LTS.

aduh95 · 2023-12-30T00:06:47Z

node/doc/contributing/backporting-to-release-lines.md

Lines 22 to 25 in 3922d18

    
           what can be landed. Our LTS release lines (see the [Release Plan][]) 
        
           require that commits mature in the Current release for at least 2 weeks before 
        
           they can be landed in an LTS staging branch. Only after "maturation" will those 
        
           commits be cherry-picked or backported.

marco-ippolito · 2024-04-29T14:48:19Z

this doesnt land cleanly on v20 needs a manual backport @nodejs/libuv

richardlau · 2024-04-29T15:39:54Z

this doesnt land cleanly on v20 needs a manual backport @nodejs/libuv

This cannot land on v20.x because it dropped support for macOS 10.x. Support was restored on libuv's v1.x branch, but not yet in a libuv release.

nodejs/node#50650

* chore: bump Node.js to v22.9.0 * build: drop base64 dep in GN build nodejs/node#52856 * build,tools: make addons tests work with GN nodejs/node#50737 * fs: add fast api for InternalModuleStat nodejs/node#51344 * src: move package_json_reader cache to c++ nodejs/node#50322 * crypto: disable PKCS#1 padding for privateDecrypt nodejs-private/node-private#525 * src: move more crypto code to ncrypto nodejs/node#54320 * crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey nodejs/node#50234 * src: shift more crypto impl details to ncrypto nodejs/node#54028 * src: switch crypto APIs to use Maybe<void> nodejs/node#54775 * crypto: remove DEFAULT_ENCODING nodejs/node#47182 * deps: update libuv to 1.47.0 nodejs/node#50650 * build: fix conflict gyp configs nodejs/node#53605 * lib,src: drop --experimental-network-imports nodejs/node#53822 * esm: align sync and async load implementations nodejs/node#49152 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * module: detect ESM syntax by trying to recompile as SourceTextModule nodejs/node#52413 * test: adapt debugger tests to V8 11.4 nodejs/node#49639 * lib: update usage of always on Atomics API nodejs/node#49639 * test: adapt test-fs-write to V8 internal changes nodejs/node#49639 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * deps: update libuv to 1.47.0 nodejs/node#50650 * src: use non-deprecated v8::Uint8Array::kMaxLength nodejs/node#50115 * src: update default V8 platform to override functions with location nodejs/node#51362 * src: add missing TryCatch nodejs/node#51362 * lib,test: handle new Iterator global nodejs/node#51362 * src: use non-deprecated version of CreateSyntheticModule nodejs/node#50115 * src: remove calls to recently deprecated V8 APIs nodejs/node#52996 * src: use new V8 API to define stream accessor nodejs/node#53084 * src: do not use deprecated V8 API nodejs/node#53084 * src: do not use soon-to-be-deprecated V8 API nodejs/node#53174 * src: migrate to new V8 interceptors API nodejs/node#52745 * src: use supported API to get stalled TLA messages nodejs/node#51362 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * test: make snapshot comparison more flexible nodejs/node#54375 * test: do not set concurrency on parallelized runs nodejs/node#52177 * src: move FromNamespacedPath to path.cc nodejs/node#53540 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * build: add option to enable clang-cl on Windows nodejs/node#52870 * chore: fixup patch indices * chore: add/remove changed files * esm: drop support for import assertions nodejs/node#54890 * build: compile with C++20 support nodejs/node#52838 * deps: update nghttp2 to 1.62.1 nodejs/node#52966 * src: parse inspector profiles with simdjson nodejs/node#51783 * build: add GN build files nodejs/node#47637 * deps,lib,src: add experimental web storage nodejs/node#52435 * build: add missing BoringSSL dep * src: rewrite task runner in c++ nodejs/node#52609 * fixup! build: add GN build files * src: stop using deprecated fields of v8::FastApiCallbackOptions nodejs/node#54077 * fix: shadow variable * build: add back incorrectly removed SetAccessor patch * fixup! fixup! build: add GN build files * crypto: fix integer comparison in crypto for BoringSSL * src,lib: reducing C++ calls of esm legacy main resolve nodejs/node#48325 * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * chore: fixup GN files for previous commit * src: move more crypto code to ncrypto nodejs/node#54320 * Fixup Perfetto ifdef guards * fix: missing electron_natives dep * fix: node_use_node_platform = false * fix: include src/node_snapshot_stub.cc in libnode * 5507047: [import-attributes] Remove support for import assertions https://chromium-review.googlesource.com/c/v8/v8/+/5507047 * fix: restore v8-sandbox.h in filenames.json * fix: re-add original-fs generation logic * fix: ngtcp2 openssl dep * test: try removing NAPI_VERSION undef * chore(deps): bump @types/node * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * buffer: fix out of range for toString nodejs/node#54553 * lib: rewrite AsyncLocalStorage without async_hooks nodejs/node#48528 * module: print amount of load time of a cjs module nodejs/node#52213 * test: skip reproducible snapshot test on 32-bit nodejs/node#53592 * fixup! src: move more crypto_dh.cc code to ncrypto * test: adjust emittedUntil return type * chore: remove redundant wpt streams patch * fixup! chore(deps): bump @types/node * fix: gn executable name on Windows * fix: build on Windows * fix: rename conflicting win32 symbols in //third_party/sqlite On Windows otherwise we get: lld-link: error: duplicate symbol: sqlite3_win32_write_debug >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:47987 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_sleep >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48042 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_is_nt >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48113 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_unicode >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48470 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_unicode_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48486 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48502 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48518 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48534 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48550 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj * docs: remove unnecessary ts-expect-error after types bump * src: move package resolver to c++ nodejs/node#50322 * build: set ASAN detect_container_overflow=0 nodejs/node#55584 * chore: fixup rebase * test: disable failing ASAN test * win: almost fix race detecting ESRCH in uv_kill libuv/libuv#4341

nodejs-github-bot added dependencies Pull requests that update a dependency file. libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels Nov 10, 2023

targos reviewed Nov 10, 2023

View reviewed changes

deps/uv/configure.ac Show resolved Hide resolved

bnoordhuis approved these changes Nov 10, 2023

View reviewed changes

richardlau approved these changes Nov 10, 2023

View reviewed changes

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2023

github-actions bot mentioned this pull request Nov 11, 2023

CI Reliability 2023-11-11 nodejs/reliability#714

Open

27 tasks

lpinca approved these changes Nov 11, 2023

View reviewed changes

This was referenced Nov 12, 2023

(Windows) FS can not handle certain characters in file name #48673

Closed

v21.2.0 release proposal #50681

Merged

richardlau mentioned this pull request Nov 16, 2023

request: access to the AIX CI Machine nodejs/build#3571

Closed

abmusse mentioned this pull request Nov 17, 2023

aix: disable ipv6 link local libuv/libuv#4229

Merged

sapphi-red mentioned this pull request Nov 22, 2023

test: skip unicode test on windows instead of lowering the Node version vitejs/vite#15096

Merged

9 tasks

LinusU mentioned this pull request Nov 29, 2023

Drop support for older versions of Node.js Automattic/node-canvas#2310

Merged

1 task

rvagg mentioned this pull request Dec 6, 2023

Failing on Node.js Windows "current" ipld/codec-fixtures#94

Open

zcbenz mentioned this pull request Dec 6, 2023

build: fix warnings from uv for gn build #51069

Merged

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023

deps: update libuv to 1.47.0

06038a4

deps: update libuv to 1.47.0 PR-URL: #50650 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

RafaelGSS mentioned this pull request Dec 15, 2023

v21.5.0 proposal #51166

Merged

AlttiRi mentioned this pull request Jan 8, 2024

v20.11.0 proposal #51124

Merged

aduh95 mentioned this pull request Jan 13, 2024

update libuv to 1.47.0 on node20 #51450

Closed

marco-ippolito added the backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. label Apr 29, 2024

richardlau added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. and removed backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. labels Apr 29, 2024

codebytere added a commit to electron/electron that referenced this pull request Oct 16, 2024

deps: update libuv to 1.47.0

0a6a576

nodejs/node#50650

codebytere added a commit to electron/electron that referenced this pull request Oct 16, 2024

deps: update libuv to 1.47.0

4d4b61b

nodejs/node#50650

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024

deps: update libuv to 1.47.0

70c5542

nodejs/node#50650

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024

deps: update libuv to 1.47.0

73c69b2

nodejs/node#50650

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024

deps: update libuv to 1.47.0

9893e1d

nodejs/node#50650

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024

deps: update libuv to 1.47.0

801b582

nodejs/node#50650

codebytere added a commit to electron/electron that referenced this pull request Oct 22, 2024

deps: update libuv to 1.47.0

a066df7

nodejs/node#50650

codebytere added a commit to electron/electron that referenced this pull request Oct 22, 2024

deps: update libuv to 1.47.0

2c99a77

nodejs/node#50650

codebytere added a commit to electron/electron that referenced this pull request Oct 28, 2024

deps: update libuv to 1.47.0

3418c48

nodejs/node#50650

codebytere added a commit to electron/electron that referenced this pull request Oct 28, 2024

deps: update libuv to 1.47.0

80090f0

nodejs/node#50650

codebytere added a commit to electron/electron that referenced this pull request Oct 29, 2024

deps: update libuv to 1.47.0

db66f61

nodejs/node#50650

codebytere added a commit to electron/electron that referenced this pull request Oct 29, 2024

deps: update libuv to 1.47.0

9857611

nodejs/node#50650

codebytere added a commit to electron/electron that referenced this pull request Oct 31, 2024

deps: update libuv to 1.47.0

0a070e9

nodejs/node#50650

codebytere added a commit to electron/electron that referenced this pull request Oct 31, 2024

deps: update libuv to 1.47.0

399f67c

nodejs/node#50650

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update libuv to 1.47.0 #50650

deps: update libuv to 1.47.0 #50650

nodejs-github-bot commented Nov 10, 2023

nodejs-github-bot commented Nov 10, 2023

bnoordhuis commented Nov 10, 2023

nodejs-github-bot commented Nov 11, 2023

abmusse commented Nov 13, 2023 •

edited

Loading

AlttiRi commented Nov 19, 2023

richardlau commented Nov 21, 2023

rvagg commented Nov 29, 2023

richardlau commented Nov 29, 2023

Rush commented Dec 29, 2023

AlttiRi commented Dec 29, 2023 •

edited

Loading

aduh95 commented Dec 30, 2023

marco-ippolito commented Apr 29, 2024

richardlau commented Apr 29, 2024

deps: update libuv to 1.47.0 #50650

deps: update libuv to 1.47.0 #50650

Conversation

nodejs-github-bot commented Nov 10, 2023

nodejs-github-bot commented Nov 10, 2023

bnoordhuis commented Nov 10, 2023

nodejs-github-bot commented Nov 11, 2023

abmusse commented Nov 13, 2023 • edited Loading

AlttiRi commented Nov 19, 2023

richardlau commented Nov 21, 2023

rvagg commented Nov 29, 2023

richardlau commented Nov 29, 2023

Rush commented Dec 29, 2023

AlttiRi commented Dec 29, 2023 • edited Loading

aduh95 commented Dec 30, 2023

marco-ippolito commented Apr 29, 2024

richardlau commented Apr 29, 2024

abmusse commented Nov 13, 2023 •

edited

Loading

AlttiRi commented Dec 29, 2023 •

edited

Loading