benchmark: add benches for fs.stat & fs.statSync #8338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
fs
|
|
||
| bench.start(); | ||
| (function r(cntr) { | ||
| if (--cntr <= 0) |
There was a problem hiding this comment.
Nit: doesn't this make the benchmark run n - 1 times?
There was a problem hiding this comment.
You’re right. I’ll fix this in the other tests, too.
Fix a off-by-one error that made the benchmarks for asynchronous functions run `n - 1` times instead of `n` times.
Add very simple benchmarks for `fs.stat` and `fs.statSync` as well as `fs.lstat` and `fs.lstatSync` based on the `readdir` benchmarks.
addaleax
force-pushed
the
bench-fs-stat
branch
from
bff12fa
to
82de541
Compare
|
LGTM |
|
LGTM. |
|
ping @mscdex |
| fn(__filename, function() { | ||
| r(cntr); | ||
| }); | ||
| }(n)); |
There was a problem hiding this comment.
Perhaps we should be passing fn into the closure as well?
There was a problem hiding this comment.
@mscdex Done, if I understood you correctly.
|
|
||
| function main(conf) { | ||
| const n = conf.n >>> 0; | ||
| const fn = fs[conf.kind]; |
There was a problem hiding this comment.
I don't know how much it matters/affects things, but maybe we should change this variable name to avoid shadowing?
There was a problem hiding this comment.
I’ve simply replaced the only use of this variable with fs[conf.kind]. It doesn’t seem to make any difference, and I would expect any difference it makes to be pretty weak in comparison to the cost of the actual syscall/thread pool operation.
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Sep 12, 2016
Fix a off-by-one error that made the benchmarks for asynchronous functions run `n - 1` times instead of `n` times. PR-URL: #8338 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Sep 12, 2016
Add very simple benchmarks for `fs.stat` and `fs.statSync` as well as `fs.lstat` and `fs.lstatSync` based on the `readdir` benchmarks. PR-URL: #8338 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
|
Landed in efabc6a and 450ee63 |
|
@jasnell Thanks for landing this! |
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
Fix a off-by-one error that made the benchmarks for asynchronous functions run `n - 1` times instead of `n` times. PR-URL: #8338 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
Add very simple benchmarks for `fs.stat` and `fs.statSync` as well as `fs.lstat` and `fs.lstatSync` based on the `readdir` benchmarks. PR-URL: #8338 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
Add very simple benchmarks for `fs.stat` and `fs.statSync` as well as `fs.lstat` and `fs.lstatSync` based on the `readdir` benchmarks. PR-URL: #8338 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
Add very simple benchmarks for `fs.stat` and `fs.statSync` as well as `fs.lstat` and `fs.lstatSync` based on the `readdir` benchmarks. PR-URL: #8338 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Add very simple benchmarks for `fs.stat` and `fs.statSync` as well as `fs.lstat` and `fs.lstatSync` based on the `readdir` benchmarks. PR-URL: #8338 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Add very simple benchmarks for `fs.stat` and `fs.statSync` as well as `fs.lstat` and `fs.lstatSync` based on the `readdir` benchmarks. PR-URL: #8338 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
benchmark
Description of change
Add very simple benchmarks for
fs.statandfs.statSyncas well asfs.lstatandfs.lstatSyncbased on thereaddirbenchmarks.Linter run: https://ci.nodejs.org/job/node-test-linter/4005/