Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add benches for fs.stat & fs.statSync #8338

Closed
wants to merge 4 commits into from
Closed

benchmark: add benches for fs.stat & fs.statSync #8338

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58f5e9b
benchmark: fix off-by-one error in fs benchmarks
addaleax Aug 30, 2016
82de541
benchmark: add benches for fs.stat & fs.statSync
addaleax Aug 30, 2016
78608a0
Pass used function directly to the closure
addaleax Sep 9, 2016
514a8a7
Maybe? simplify function call/remove variable shadowing
addaleax Sep 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmark/fs/bench-readdir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function main(conf) {

bench.start();
(function r(cntr) {
if (--cntr <= 0)
if (cntr-- <= 0)
return bench.end(n);
fs.readdir(path.resolve(__dirname, '../../lib/'), function() {
r(cntr);
Expand Down
4 changes: 2 additions & 2 deletions benchmark/fs/bench-realpath.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function main(conf) {

function relativePath(n) {
(function r(cntr) {
if (--cntr <= 0)
if (cntr-- <= 0)
return bench.end(n);
fs.realpath(relative_path, function() {
r(cntr);
Expand All @@ -37,7 +37,7 @@ function relativePath(n) {

function resolvedPath(n) {
(function r(cntr) {
if (--cntr <= 0)
if (cntr-- <= 0)
return bench.end(n);
fs.realpath(resolved_path, function() {
r(cntr);
Expand Down
24 changes: 24 additions & 0 deletions benchmark/fs/bench-stat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
'use strict';

const common = require('../common');
const fs = require('fs');

const bench = common.createBenchmark(main, {
n: [1e4],
kind: ['lstat', 'stat']
});


function main(conf) {
const n = conf.n >>> 0;
const fn = fs[conf.kind];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how much it matters/affects things, but maybe we should change this variable name to avoid shadowing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve simply replaced the only use of this variable with fs[conf.kind]. It doesn’t seem to make any difference, and I would expect any difference it makes to be pretty weak in comparison to the cost of the actual syscall/thread pool operation.


bench.start();
(function r(cntr, fn) {
if (cntr-- <= 0)
return bench.end(n);
fn(__filename, function() {
r(cntr, fn);
});
}(n, fn));
}
21 changes: 21 additions & 0 deletions benchmark/fs/bench-statSync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
'use strict';

const common = require('../common');
const fs = require('fs');

const bench = common.createBenchmark(main, {
n: [1e4],
kind: ['lstatSync', 'statSync']
});


function main(conf) {
const n = conf.n >>> 0;
const fn = fs[conf.kind];

bench.start();
for (var i = 0; i < n; i++) {
fn(__filename);
}
bench.end(n);
}