Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change var to const or let in test-child-process-ipc.js #9990

Closed
wants to merge 1 commit into from

Conversation

malenesok007
Copy link
Contributor

@malenesok007 malenesok007 commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@imyller
Copy link
Member

imyller commented Dec 1, 2016

@malenesok007 May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines.

@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Dec 1, 2016
@malenesok007
Copy link
Contributor Author

Hi I have modify the commit message. Is there something I am missing? Thanks.

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI.

@Trott
Copy link
Member

Trott commented Dec 8, 2016

let gotHelloWorld = false;
let gotEcho = false;

let child = spawn(process.argv[0], [sub]);
Copy link
Contributor

@silverwind silverwind Dec 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter error here:

 error  'child' is never reassigned. Use 'const' instead  prefer-const

@Trott
Copy link
Member

Trott commented Dec 22, 2016

Ping @malenesok007: Can you change the let to const as identified in the comment from @silverwind? You can run make jslint (or, if on Windows, vcbuild jslint nosign I think) to check for other lint errors before pushing.

@Trott
Copy link
Member

Trott commented Dec 24, 2016

Because it was a straightforward lint fix, I made the change and pushed it to @malenesok007's branch.

@silverwind Can you take a look and, if appropriate, update your review? Thanks!

@Trott
Copy link
Member

Trott commented Dec 24, 2016

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 24, 2016
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: nodejs#9990
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@Trott
Copy link
Member

Trott commented Dec 24, 2016

Landed in ff88a5a.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 24, 2016
targos pushed a commit that referenced this pull request Dec 26, 2016
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 27, 2016
targos pushed a commit that referenced this pull request Dec 28, 2016
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2017
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants