Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change var to const or let in test-child-process-ipc.js #9990

Closed
wants to merge 1 commit into from
Closed

Change var to const or let in test-child-process-ipc.js #9990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions test/parallel/test-child-process-ipc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
'use strict';
var common = require('../common');
var assert = require('assert');

var spawn = require('child_process').spawn;
const common = require('../common');
const assert = require('assert');

var path = require('path');
const spawn = require('child_process').spawn;

var sub = path.join(common.fixturesDir, 'echo.js');
const path = require('path');

var gotHelloWorld = false;
var gotEcho = false;
const sub = path.join(common.fixturesDir, 'echo.js');

var child = spawn(process.argv[0], [sub]);
let gotHelloWorld = false;
let gotEcho = false;

const child = spawn(process.argv[0], [sub]);

child.stderr.on('data', function(data) {
console.log('parent stderr: ' + data);
Expand All @@ -23,7 +24,7 @@ child.stdout.on('data', function(data) {
console.log('child said: ' + JSON.stringify(data));
if (!gotHelloWorld) {
console.error('testing for hello world');
assert.equal('hello world\r\n', data);
assert.strictEqual('hello world\r\n', data);
gotHelloWorld = true;
console.error('writing echo me');
child.stdin.write('echo me\r\n');
Expand Down