Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guides: add ABI stability guide #1828

Closed
wants to merge 1 commit into from
Closed

guides: add ABI stability guide #1828

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link

No description provided.

@gabrielschulhof
Copy link
Author

@mhdawson @gireeshpunathil @benjamingr I have moved the guide to this repo so it might appear on the Web site. Could you PTAL?

This was referenced Oct 7, 2018
Closed
Closed
benjamingr
benjamingr approved these changes Oct 7, 2018
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I didn't get a chance to respond to the feedback initially but this is much better and I still really like having this guide.

Nice work! <3

@vsemozhetbyt vsemozhetbyt added the content Issues/pr concerning content label Oct 7, 2018
@gabrielschulhof
Copy link
Author

@benjamingr thanks!

@gabrielschulhof
Copy link
Author

Whoops! Forgot to add to index.md.

lpinca
lpinca reviewed Oct 7, 2018
View reviewed changes
locale/en/docs/guides/abi-stability.md Show resolved Hide resolved
locale/en/docs/guides/abi-stability.md Outdated
into a forthcoming version of N-API. That is, an experimental N-API is not yet
covered by the forward compatibility guarantee.

[`node_api.h`]: ../../src/node_api.h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these links don't work.

@gabrielschulhof
Copy link
Author

@lpinca I have addressed your comments.

gabrielschulhof pushed a commit that referenced this pull request Oct 9, 2018
guides: add ABI stability guide
3214a8d 
PR-URL: #1828
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Milos Jevtovic <[email protected]>
@gabrielschulhof
Copy link
Author

Landed in 3214a8d.

@gabrielschulhof gabrielschulhof deleted the add-abi-stability-guide branch October 9, 2018 01:46
@ghost ghost mentioned this pull request Oct 14, 2018
Merged
stevemao pushed a commit that referenced this pull request Oct 17, 2018
@stevemao
zh-CN: New translation for 'abi-stability.md' (#1839)
8df9153 
Ref: #1828
@snyk-bot snyk-bot mentioned this pull request Dec 30, 2020
Merged
@NOUIY NOUIY mentioned this pull request Nov 30, 2022
Open
@Redwoodtj Redwoodtj mentioned this pull request Nov 30, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 2, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 24, 2022
Open
@dirgam92 dirgam92 mentioned this pull request Mar 14, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
content Issues/pr concerning content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gabrielschulhof @Trott @benjamingr @lpinca @gireeshpunathil @vsemozhetbyt