Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-CN: New translation for 'abi-stability.md' #1839

Merged
merged 1 commit into from Oct 17, 2018
Merged

zh-CN: New translation for 'abi-stability.md' #1839

merged 1 commit into from Oct 17, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 14, 2018

Ref: #1828

@nodejs/nodejs-cn

Copy link
Contributor

@willin willin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

locale/zh-cn/docs/guides/abi-stability.md Outdated Show resolved Hide resolved
@stevemao stevemao added the i18n Issues/PRs related to the Website Internationalisation label Oct 15, 2018
Copy link
Contributor

@marswong marswong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议边机翻边检查语法问题,不然校对成本太高🙈

locale/zh-cn/docs/guides/abi-stability.md Outdated Show resolved Hide resolved
locale/zh-cn/docs/guides/index.md Outdated Show resolved Hide resolved
locale/zh-cn/docs/guides/abi-stability.md Outdated Show resolved Hide resolved
locale/zh-cn/docs/guides/abi-stability.md Show resolved Hide resolved
locale/zh-cn/docs/guides/abi-stability.md Outdated Show resolved Hide resolved
locale/zh-cn/docs/guides/abi-stability.md Show resolved Hide resolved
locale/zh-cn/docs/guides/abi-stability.md Outdated Show resolved Hide resolved
Copy link
Contributor

@stevemao stevemao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it!
Any other improvements just make another PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants