-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported versions #1832
Conversation
@@ -78,21 +78,24 @@ sudo apt-get install -y build-essential | |||
|
|||
**Available architectures:** | |||
|
|||
* **i386** (32-bit) | |||
* **i386** (32-bit)—**not available for Node.js 10 and later** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: let's use m-dash or hyphen with spaces consistently (compare additions below)?
* **Ubuntu 16.04 LTS** (Xenial Xerus) | ||
* **Ubuntu 17.10** (Artful Aardvark) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
17.10 went EOL, so it not supported anymore...
I'm kinda in favor of just linking instead of C&P content (for example next week we're gonna have node v11 as well)... |
85981f1
to
ceb9077
Compare
90b17df
to
2ccf48a
Compare
Okay, I removed the whole Debian/Ubuntu/RHEL section and replaced it with a link to the NodeSource repo. We still need translations/updated for those pages:
|
I can help with the Spanish translation |
Co-Authored-By: fhemberger <[email protected]>
@academo Thanks! |
uk/download/package-manager.md has not translated text, it seems it's just a placeholder. It can be deleted or replaced by the en/download/package-manager.md. |
Great, only two more to go. |
I also added missing Android and Solus descriptions to es/ja/ko (untranslated). |
Thank you all for your help! |
This PR fixes some missing Korean translations in #1832. Ref:nodejs/nodejs-ko#763
Updated supported versions, as mentioned in #1831.
However, I noticed that the two documents seem to be drifting apart in other sections. So we should really think about how we want to handle this in the future. That's also the reason I didn't update all distros.
/cc @bnb @rvagg Any ideas on how to proceed?