Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported versions #1832

Merged
merged 10 commits into from
Oct 28, 2018
Merged

Update supported versions #1832

merged 10 commits into from
Oct 28, 2018

Conversation

fhemberger
Copy link
Contributor

Updated supported versions, as mentioned in #1831.

However, I noticed that the two documents seem to be drifting apart in other sections. So we should really think about how we want to handle this in the future. That's also the reason I didn't update all distros.

/cc @bnb @rvagg Any ideas on how to proceed?

@fhemberger fhemberger requested review from rvagg and bnb October 10, 2018 08:18
@@ -78,21 +78,24 @@ sudo apt-get install -y build-essential

**Available architectures:**

* **i386** (32-bit)
* **i386** (32-bit)—**not available for Node.js 10 and later**
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt Oct 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: let's use m-dash or hyphen with spaces consistently (compare additions below)?

* **Ubuntu 16.04 LTS** (Xenial Xerus)
* **Ubuntu 17.10** (Artful Aardvark)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

17.10 went EOL, so it not supported anymore...

@refack
Copy link
Contributor

refack commented Oct 10, 2018

I'm kinda in favor of just linking instead of C&P content (for example next week we're gonna have node v11 as well)...
Maybe just leave a line about supported (as in not EOL RE nodejs/Release#359) node versions on supported distro versions.

@fhemberger
Copy link
Contributor Author

fhemberger commented Oct 25, 2018

Okay, I removed the whole Debian/Ubuntu/RHEL section and replaced it with a link to the NodeSource repo.

We still need translations/updated for those pages:

  • @nodejs/nodejs-es
  • @nodejs/nodejs-ja
  • @nodejs/nodejs-ko
  • @nodejs/nodejs-uk
  • @nodejs/nodejs-cn
  • @nodejs/nodejs-tw

@fhemberger fhemberger added the i18n Issues/PRs related to the Website Internationalisation label Oct 25, 2018
@academo
Copy link
Contributor

academo commented Oct 25, 2018

I can help with the Spanish translation

locale/es/download/package-manager.md Outdated Show resolved Hide resolved
@fhemberger
Copy link
Contributor Author

@academo Thanks!

@vsemozhetbyt
Copy link
Contributor

uk/download/package-manager.md has not translated text, it seems it's just a placeholder. It can be deleted or replaced by the en/download/package-manager.md.

@fhemberger
Copy link
Contributor Author

Great, only two more to go.

@fhemberger
Copy link
Contributor Author

I also added missing Android and Solus descriptions to es/ja/ko (untranslated).
Those can be translated in a separate PR as well, as I think it's more important to have the content up to date.

@fhemberger fhemberger merged commit aeb8963 into master Oct 28, 2018
@fhemberger fhemberger deleted the fix/package-manager branch October 28, 2018 03:38
@fhemberger
Copy link
Contributor Author

Thank you all for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants