-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Korean translation for package-manager.md #1979
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but one comment.
Is there a way to enforce to generate anchor with specified name? Variations between languages can make some confusions. |
@taggon Can you give me a feedback of the suggestion? |
Use the pure HTML to fix the anchor link
@Maledong It seems that <h2 id="header-android">Android<a name="android" class="anchor" href="#android" aria-labelledby="header-android"></a></h2> |
@yous:Yeah, I've noticed that but it doesn't effect, and everything seems fine, if we keep the name, link the same name as what we see in the title. |
@Maledong Got it, thanks! I think this is ready to be merged. |
Oh wait, the file has multiple headers with CJK. |
@yous:No problem. If anything else welcome to have a discussion with me or all of you here to fix it:) |
@Maledong Thank you for participating and fixing this issue! Now it's really ready to be merged. |
Nice! Thanks and I've helped to merge your change. |
This PR fixes some missing Korean translations in #1832.
ref nodejs/nodejs-ko#763
cc @nodejs/nodejs-ko