Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #239 #240

Merged
merged 2 commits into from
Nov 19, 2023
Merged

fix #239 #240

merged 2 commits into from
Nov 19, 2023

Conversation

ashidaharo
Copy link
Contributor

fix #239

note: In order to create this fix, 
      I also looked at lib/nodist.js for reference, which is supposed to handle "latest" as well, 
      and found out that they use lib/version.js to handle versions. 
      Unlike lib/nodist/js, lib/npm.js has to deal with "match", 
      so it seems to have its own version handling defined.
      Following the philosophy that if you don't need to make a big change, you shouldn't, 
      I've limited myself to a small fix to npm.js. 
      But I'm curious, so I'll make a special note here.

@ashidaharo
Copy link
Contributor Author

Is there a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"nodist latest" looks buggy to me.
2 participants