-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix most issues: npm8 support, github actions, npx shim #258
Conversation
This reverts commit 710c27c.
This replaces the old `github` package with the latest Octokit REST client which makes authentication work again. Additionally, the `NODIST_GITHUB_TOKEN` environment variable can now be used to supply a token for authenticating GitHub requests (and overcoming the unauthenticated request rate limit).
- download used NSIS plugins before build and use them from that local folder - raise minimum node version (needed for building and using nodist) to 12
@Mairu Do you have an installer? Tried to build one from your fork but got errors. |
Hi, it seems the npm version cannot be fetched since something has changed in the meantime. I can perhaps take a look at the weekend and will build a version in my forked repo. |
@Mairu No stress, I just returned the latest npm version from that function (without making the http request.) Then the build completed without errors. Thank you for the fork :) |
I fixed the issue, so the build works again. Also created a pre-release in my repo if anybody is interested in using it -> https://github.com/Mairu/nodist/releases/tag/v0.10.0-beta.2 |
Thank you for the work. I will review this and work on an official build. |
I also have just the information from this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently I have collab rights again 🤷 🎉
Cool, can you create a new release pls? @marcelklehr |
This PR / branch also includes the open PR #240 and #246.